chore: type Provider.list() as Record<ProviderID, Info>, delete dead code#18123
Merged
kitlangton merged 1 commit intodevfrom Mar 18, 2026
Merged
chore: type Provider.list() as Record<ProviderID, Info>, delete dead code#18123kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
kitlangton
force-pushed
the
chore/effect-cleanup
branch
from
c3b7eb2 to
54aabdd
Compare
…d eventloop.ts - Provider.list() return type narrowed from Record<string, Info> to Record<ProviderID, Info> - Added gitlab to well-known ProviderID constants - Updated all test string-literal indexing to use ProviderID.make() or well-known constants (ProviderID.anthropic, etc.) - Deleted src/util/eventloop.ts (zero imports, dead code)
kitlangton
force-pushed
the
chore/effect-cleanup
branch
from
54aabdd to
1346c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provider.list()return type narrowed fromRecord<string, Info>toRecord<ProviderID, Info>— catches string-indexed access at compile timegitlabto well-knownProviderIDconstantsProviderID.make()or well-known constants (ProviderID.anthropic,ProviderID.amazonBedrock, etc.)src/util/eventloop.ts(zero imports, dead code)Test plan
tsc --noEmitpasses