feat: manage custom providers within model settings#18550
Open
neversaywanan wants to merge 2 commits intoanomalyco:devfrom
Open
feat: manage custom providers within model settings#18550neversaywanan wants to merge 2 commits intoanomalyco:devfrom
neversaywanan wants to merge 2 commits intoanomalyco:devfrom
Conversation
Replace patched provider configs instead of deep-merging stale model keys, and refresh model/settings dialogs from the latest backend state. Add regression tests for both json and jsonc global config updates to ensure deleted custom models stay deleted.
Author
|
@adamdotdevin Hi! The CI shows “This workflow requires approval from a maintainer” (3 workflows awaiting approval). Could you please click Approve and run for this PR? I don’t have the permissions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18224
Type of change
What does this PR do?
Adds an edit flow for custom providers from the model settings page.
Custom providers now show an
Editaction inSettings > Models, which opens the existing custom provider dialog in edit mode. The form is prefilled from the current provider config, keeps the provider ID locked while editing, and updates the saved config without failing duplicate ID validation for the provider being edited.When models are removed during editing, they are moved into the provider blacklist so hidden models stay hidden instead of reappearing when the provider is saved again.
How did you verify your code works?
bun test --preload ./happydom.ts ./src/components/dialog-custom-provider.test.tsfrompackages/appScreenshots / recordings
TODO: add before/after screenshots or a short recording of editing a custom provider from
Settings > Models2026-03-22.02.30.07.mov
Checklist