fix(tag list): change sorting to avoid bug#346
Open
sanderob wants to merge 1 commit intoanothrNick:masterfrom
Open
fix(tag list): change sorting to avoid bug#346sanderob wants to merge 1 commit intoanothrNick:masterfrom
sanderob wants to merge 1 commit intoanothrNick:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
When there are several tags on one commit, the tags with common commit arrive in the opposite order when using
sort=-committerdate. When usingsort=committerdate, the latest tag is at the bottom of the list, but the tags arrive in the correct order, even when there are several tags on one commit.This pull request solves #345.
For instance, with the following git log:
commit abc123 (tag: v0.0.3, tag: v0.0.2, master) Author: github-author Date: Wed Jul 23 16:24:51 2025 +0200 Commit message 2 commit xyz789 (tag: v0.0.1) Author: github-author Date: Wed Jul 23 16:05:26 2025 +0200 Commit message 1The command
git tag --list --sort=-committerdatewill yield:And the action will try to bump from v0.0.2. However, the command
git tag --list --sort=committerdatewill yield:Which will, in combination with
tail -n 1instead ofhead -n 1, make the action bump from v0.0.3Breaking Changes
Do any of the included changes break current behavior or configuration?
NO
How changes have been tested
Yes
List any unknowns
None known.