on multiple tags on the same commit, take the highest one#348
Closed
nirroz93 wants to merge 1 commit intoanothrNick:masterfrom
Closed
on multiple tags on the same commit, take the highest one#348nirroz93 wants to merge 1 commit intoanothrNick:masterfrom
nirroz93 wants to merge 1 commit intoanothrNick:masterfrom
Conversation
Author
|
Actually, there is already a PR to fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
When multiple tags exists for the latest version, choose the highest instead of the first.
If user sets FORCE_WITHOUT_CHANGES: true and TAG_CONTEXT: branch, this creates a situation that if a commit has 2 tags, the next run (whether with or without changes) will collide with the previous tag
Breaking Changes
Do any of the included changes break current behaviour or configuration?
No
How changes have been tested
On a private repo, the change fixed the issue. I will note that anyway, it replaces the head -n1, so it only relevant when there are multiple tags on the same commit
List any unknowns