[#1842] [AMQ-9858] Support purging the first number of messages from a queue#1662
Open
mattrpav wants to merge 1 commit intoapache:mainfrom
Open
[#1842] [AMQ-9858] Support purging the first number of messages from a queue#1662mattrpav wants to merge 1 commit intoapache:mainfrom
mattrpav wants to merge 1 commit intoapache:mainfrom
Conversation
mattrpav
changed the title
mattrpav
changed the title
jbonofre
requested changes
Mar 27, 2026
| * @throws Exception | ||
| */ | ||
| @MBeanInfo("Removes the first number of messages in the queue.") | ||
| void purge(long number) throws Exception; |
Member
There was a problem hiding this comment.
nit: for the reader, we could have use numberOfMessages here (to be consistent with QueueView interface).
| } | ||
|
|
||
| public void purge(long numberOfMessages) throws Exception { | ||
| ConnectionContext c = createConnectionContext(); |
Member
There was a problem hiding this comment.
We should add numberOfMessages validation here:
Suggested change
| ConnectionContext c = createConnectionContext(); | |
| if (numberOfMessages <= 0) { | |
| return; | |
| } | |
| ConnectionContext c = createConnectionContext(); |
Else, it means that this method will acquire sendLock, create ConnectionContext and go in the loop even if the number of messages to purge is invalid.
|
|
||
| long purgeCount = 0L; | ||
| try { | ||
| long originalMessageCount = this.destinationStatistics.getMessages().getCount(); |
Member
There was a problem hiding this comment.
With the change, originalMessageCount is not used anymore, it can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: [#1842]
ref: [AMQ-9858]