AMQ-9857: Support broker-level SSL fallback in ManagementContext to eliminate duplicate SSL configuration#1710
AMQ-9857: Support broker-level SSL fallback in ManagementContext to eliminate duplicate SSL configuration#1710anmol-saxena-14 wants to merge 3 commits intoapache:mainfrom
Conversation
|
Hi, |
|
Hi, |
|
@asaxena14 So, if I understand, we need to somehow merge our 2 PRs, right? |
| // Reuse the broker-level SSL context for JMX by default | ||
| // This avoids duplicating SSL config in activemq.xml while still allowing an | ||
| // explicit managementContext sslContext to override when one is needed | ||
| if (getManagementContext().getSslContext() == null && getSslContext() != null) { |
There was a problem hiding this comment.
There is a logic flaw here-- just b/c an SslContext exists on the broker, does not mean the intent is to wire it to the management context.
If there is a fallback option, there most likely will need to be a config flag on the managementContext to affirm that ssl should be enabled.
There was a problem hiding this comment.
I agree, the PR #1661 already supports explicit wiring via: " ". Adding a fallback code, guarded by an explicit flag, does not seem necessary and would add complexity without clear benefit.
|
This is already covered by PR #1661. |
3 participants
No description provided.