Skip to content

[#1826] fix(test): Fix flakiness in AMQ4930Test #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gurpartap3697 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −7
Open

[#1826] fix(test): Fix flakiness in AMQ4930Test #1825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ4930Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,18 +109,14 @@ public void doTestBrowsePending(int deliveryMode) throws Exception {
browsed = underTest.browse();
LOG.info("Browsed: " + browsed.length);
assertEquals("maxBrowsePageSize", maxBrowsePageSize, browsed.length);
Runtime.getRuntime().gc();
long free = Runtime.getRuntime().freeMemory()/1024;
LOG.info("free at start of check: " + free);
long memoryUsageAtStart = underTest.getMemoryUsage().getUsage();
LOG.info("Memory usage at start of check: " + memoryUsageAtStart);
// check for memory growth
for (int i=0; i<10; i++) {
LOG.info("free: " + Runtime.getRuntime().freeMemory()/1024);
browsed = underTest.browse();
LOG.info("Browsed: " + browsed.length);
assertEquals("maxBrowsePageSize", maxBrowsePageSize, browsed.length);
Runtime.getRuntime().gc();
Runtime.getRuntime().gc();
assertTrue("No growth: " + Runtime.getRuntime().freeMemory()/1024 + " >= " + (free - (free * 0.2)), Runtime.getRuntime().freeMemory()/1024 >= (free - (free * 0.2)));
assertTrue("Memory usage is ballooning: " + underTest.getMemoryUsage().getUsage() + " > " + (memoryUsageAtStart * 1.1), underTest.getMemoryUsage().getUsage() <= (memoryUsageAtStart * 1.1));
}
}

Expand Down
Loading