Add gRPC timeout to Secret Manager access_secret_version call#63813
Draft
evgeniy-b wants to merge 1 commit intoapache:mainfrom
Draft
Add gRPC timeout to Secret Manager access_secret_version call#63813evgeniy-b wants to merge 1 commit intoapache:mainfrom
access_secret_version call#63813evgeniy-b wants to merge 1 commit intoapache:mainfrom
Conversation
The `_SecretManagerClient.get_secret()` calls `access_secret_version()` with no timeout, so the gRPC call has no deadline. If Secret Manager is slow or unreachable the calling thread blocks indefinitely. Add a 30 s gRPC deadline and re-raise `DeadlineExceeded` as `TimeoutError`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
@evgeniy-b This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_SecretManagerClient.get_secret()callsaccess_secret_version()with notimeoutparameter, meaning the gRPC call has no deadline. If Secret Manager is slow or unreachable, the calling thread blocks indefinitely.This is particularly problematic in the triggerer, where Secret Manager calls run in the shared
sync_to_asyncthread pool. A single stuck call can exhaust the pool, blocking all triggers.Changes
timeout=30) to theaccess_secret_versioncall in_SecretManagerClient.get_secret()DeadlineExceededand re-raise as PythonTimeoutErrorso callers can handle it with standard exception handlingThe
timeoutkwarg sets a gRPC deadline enforced at the C level inside grpc-core. When the deadline expires, grpc-core cancels the RPC and the thread unblocks with aDeadlineExceedederror — unlike Python-level timeouts which cannot interrupt threads blocked in C code.Why
TimeoutErrorinstead of returningNone?Returning
Nonewould mean "secret doesn't exist," which is semantically wrong for a timeout — the secret may exist, we just couldn't reach it. The secrets backend framework inConnection.get_connection_from_secrets()already catchesExceptionand falls through to the next backend, so re-raising is safe and preserves the distinction.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.6 following the guidelines