Fix coroutine serialization error in PowerBIDatasetRefreshOperator#63829
Open
henry3260 wants to merge 1 commit intoapache:mainfrom
Open
Fix coroutine serialization error in PowerBIDatasetRefreshOperator#63829henry3260 wants to merge 1 commit intoapache:mainfrom
henry3260 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
cc @morelgeorge |
Contributor
SameerMesiah97
left a comment
There was a problem hiding this comment.
I think you found the cause but I feel the fix might be at the wrong layer. Also, did you manage to reproduce the bug locally?
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/powerbi.py
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks for reviewing! Yes, I reproduced the error locally with the unit test. |
6978c2d to
8b7e0c8
Compare
8b7e0c8 to
0593eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When the
PowerBIDatasetRefreshOperatoris executed withwait_for_completion=False, it takes the synchronous"fire-and-forget" path. However, the underlying hook methodtrigger_dataset_refreshis an async function.What
Forced Synchronous Execution: Wrapped the
hook.trigger_dataset_refresh(...)call withasyncio.run(...)inside thewait_for_completion=Falseblock. This ensures the async hook method executes fully within the current synchronous thread and returns the actual string ID.closes: #63811
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.