Skip to content

Revert run test filtering logic not to skip pytest by breeze#63870

Merged
potiuk merged 1 commit intoapache:mainfrom
wjddn279:fix-run-test-filtering
Mar 18, 2026
Merged

Revert run test filtering logic not to skip pytest by breeze#63870
potiuk merged 1 commit intoapache:mainfrom
wjddn279:fix-run-test-filtering

Conversation

@wjddn279
Copy link
Contributor

related: #63793

Unit tests in Breeze that were previously passing have stopped running.

breeze testing core-tests --backend sqlite airflow-core/tests/unit/serialization/test_helpers.py

It was identified that a change to the pytest skip logic in this PR caused these tests to be filtered out. Commands like the one above have a test_type of "None", which means the args start with -- from the beginning, causing them to always be caught by the filtering logic. Reverted the filtering logic to its original implementation.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@potiuk potiuk merged commit dfca2cd into apache:main Mar 18, 2026
134 checks passed
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker dfca2cd v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@potiuk
Copy link
Member

potiuk commented Mar 18, 2026

@Dev-iL => this is somethign to handle better for 3.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants