Skip to content

fix: Populate the protocol version of the original request to the ups…#12842

Closed
zhl11b wants to merge 1 commit intoapache:masterfrom
zhl11b:master
Closed

fix: Populate the protocol version of the original request to the ups…#12842
zhl11b wants to merge 1 commit intoapache:masterfrom
zhl11b:master

Conversation

@zhl11b
Copy link
Copy Markdown

@zhl11b zhl11b commented Dec 25, 2025

Description

fix: Populate the protocol version of the original request to the ups…
If the version is not passed, upstream may use the default version, leading to inconsistent behavior or compatibility issues.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 25, 2025
Copy link
Copy Markdown
Contributor

@Baoyuantop Baoyuantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no test cases for this modification.

@Baoyuantop Baoyuantop added the wait for update wait for the author's response in this issue/PR label Jan 26, 2026
@Baoyuantop
Copy link
Copy Markdown
Contributor

Hi @zhl11b, following up on the previous review comments. Please let us know if you have any updates. Thank you.

@moonming moonming closed this Mar 16, 2026
@moonming
Copy link
Copy Markdown
Member

Hi @zhl11b, thank you for submitting this!

I have a few concerns with the current state of this PR:

  1. Missing context: There's no associated issue describing the problem this fixes. Could you share the specific scenario where you encountered this issue?

  2. No test coverage: The single-line change to ext-plugin-post-resp.lua doesn't have any accompanying tests to verify the fix and prevent regression.

  3. Unclear impact: Without a clear description of the bug and steps to reproduce, it's difficult to validate whether this change is correct and doesn't introduce side effects.

Since this has been inactive for several months, I'm going to close this PR. If you're still experiencing the issue, please:

  1. Open an issue first describing the problem with reproduction steps
  2. Submit a new PR with the fix and test cases that demonstrate the before/after behavior

Thanks for your interest in improving APISIX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files. wait for update wait for the author's response in this issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants