Skip to content

fix(conf): correct AI plugin priority comments in config.yaml.example#12926

Merged
Baoyuantop merged 1 commit intoapache:masterfrom
sihyeonn:feat/sh-example-priority
Mar 18, 2026
Merged

fix(conf): correct AI plugin priority comments in config.yaml.example#12926
Baoyuantop merged 1 commit intoapache:masterfrom
sihyeonn:feat/sh-example-priority

Conversation

@sihyeonn
Copy link
Copy Markdown
Contributor

@sihyeonn sihyeonn commented Jan 20, 2026

Description

Fix incorrect priority comments for AI plugins in config.yaml.example.

The following plugins had wrong priority values in comments:

  • ai-proxy: 999 → 1040
  • ai-proxy-multi: 998 → 1041
  • ai-aws-content-moderation: 1040 → 1050

Also reordered these plugins to match their actual priority values (sorted by descending priority).

Which issue(s) this PR fixes:

Fixes #

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

- ai-proxy: 999 → 1040
- ai-proxy-multi: 998 → 1041
- ai-aws-content-moderation: 1040 → 1050

Also reorder plugins to match actual priority values.

Signed-off-by: Sihyeon Jang <sihyeon.jang@navercorp.com>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 20, 2026
Copy link
Copy Markdown
Contributor

@Baoyuantop Baoyuantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add the ai-aliyun-content-moderation and ai-request-rewrite plugins.

@Baoyuantop Baoyuantop added the wait for update wait for the author's response in this issue/PR label Jan 26, 2026
@sihyeonn
Copy link
Copy Markdown
Contributor Author

@Baoyuantop Thanks for the suggestion! This PR focuses on fixing the existing issue. I'll add those plugins in a separate PR.

@Baoyuantop
Copy link
Copy Markdown
Contributor

Hi @sihyeonn, I believe this falls under a category of issues that should be addressed collectively in the current PR.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes misleading priority comments for AI plugins in config.yaml.example by updating the annotated priorities and reordering the entries to match actual descending priority.

Changes:

  • Corrected priority comment values for ai-proxy, ai-proxy-multi, and ai-aws-content-moderation
  • Reordered AI plugin entries to maintain descending-priority sorting
  • Removed an outdated TODO tied to the incorrect priority comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Baoyuantop Baoyuantop merged commit a8b07ff into apache:master Mar 18, 2026
28 checks passed
Baoyuantop added a commit to Baoyuantop/apisix that referenced this pull request Mar 19, 2026
Add missing plugins to conf/config.yaml.example:
- ai-request-rewrite (priority: 1073)
- ai-aliyun-content-moderation (priority: 1029)
- traffic-split in stream_plugins (priority: 966)

Reorder AI plugins by descending priority in both
conf/config.yaml.example and apisix/cli/config.lua.

Also move ai-request-rewrite from the end of the plugin list in
apisix/cli/config.lua to its correct position by priority.

Follow-up to apache#12926.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. wait for update wait for the author's response in this issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants