Skip to content

feat(rust/driver_manager): Decouple driver search logic from the driver objects themselves #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felipecrv merged 34 commits into from
Feb 12, 2026
Merged

feat(rust/driver_manager): Decouple driver search logic from the driver objects themselves #3930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
532fe77
Move code to new search.rs without any refactoring
felipecrv Jan 28, 2026
6021534
Add the DriverLibrary struct and move get_default_entrypoint to it
felipecrv Jan 28, 2026
117d84e
Introduce an enum representing the driver init function (static or dy…
felipecrv Jan 28, 2026
1104266
Load the Symbol from DriverLibrary constructor
felipecrv Jan 28, 2026
20f701d
Move the library loading code to DriverLibrary
felipecrv Jan 28, 2026
062925c
DEBUG: print library probes
felipecrv Jan 29, 2026
f13db4c
Remove unnecessary to_string()
felipecrv Jan 28, 2026
83dd8c3
Remove all the mut's in get_default_entrypoint
felipecrv Jan 28, 2026
33cf5a2
Extract get_default_entrypoint_from_name() from get_default_entrypoint()
felipecrv Jan 28, 2026
01f3b3a
Remove the entrypoint parameter from DriverInfo::load_driver_manifest()
felipecrv Jan 28, 2026
0877fdf
Use pattern matching to process the toml manifest
felipecrv Jan 28, 2026
e45a90e
Add DriverLibrary::{load_library_from_name,load_library_from_manifest}
felipecrv Jan 29, 2026
71d40ad
Use .find_map() in search_path_list()
felipecrv Jan 29, 2026
7226479
Add trace parameter to search_path_list()
felipecrv Jan 29, 2026
b84a34d
Move the search_path_list() logic to DriverLibrary
felipecrv Jan 29, 2026
4d0b28c
DEBUG: print the trace
felipecrv Jan 29, 2026
e0ed5eb
Append search_path_list() error to trace in find_driver()
felipecrv Jan 29, 2026
09730b2
Add a copy of load_driver_from_registry to DriverLibrary
felipecrv Jan 29, 2026
5671639
Use DriverLibrary::load_from_registry() without an entrypoint parameter
felipecrv Jan 29, 2026
5af9c00
Add DriverLibrary::load_library_from_registry
felipecrv Jan 29, 2026
d41e7fd
Make find_driver() concern itself with only the search for the library
felipecrv Jan 29, 2026
27b1eb0
FIX: The equivalent to previous version is the load_library_from_name()
felipecrv Jan 29, 2026
bb9e051
Move find_driver() to DriverLibrary
felipecrv Jan 29, 2026
a883d95
Write load_from_name() as a single block expression
felipecrv Jan 29, 2026
eeeb972
De-dup the entrypoint derivation logic
felipecrv Jan 29, 2026
fc3a535
Add the SearchHit struct
felipecrv Jan 29, 2026
9de4225
FIX: Windows-specific imports
felipecrv Jan 29, 2026
793b71a
Extract DriverLibrary::search() function
felipecrv Feb 11, 2026
a73aedf
More entrypoint logic extracted
felipecrv Feb 11, 2026
b99d5dd
Move tests from lib.rs to search.rs
felipecrv Feb 11, 2026
6dd4b7a
Put the trace in the error details
felipecrv Feb 11, 2026
7bac246
Clarify trace ownership rules
felipecrv Feb 11, 2026
91659ec
Do as Windows CI tells
felipecrv Feb 11, 2026
25ffa93
Remove the unecesary pub(crate) from search.rs
felipecrv Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading