Skip to content

refactor(rust/core): moved adbc traits to sync mod#3932

Merged
lidavidm merged 1 commit intoapache:mainfrom
if0ne:refactor/trait-mod
Feb 9, 2026
Merged

refactor(rust/core): moved adbc traits to sync mod#3932
lidavidm merged 1 commit intoapache:mainfrom
if0ne:refactor/trait-mod

Conversation

@if0ne
Copy link
Contributor

@if0ne if0ne commented Jan 30, 2026

A small step toward implementing #3714

Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
@if0ne if0ne requested a review from wjones127 as a code owner January 30, 2026 09:41
@if0ne
Copy link
Contributor Author

if0ne commented Jan 30, 2026

СС @lidavidm

@lidavidm
Copy link
Member

While I'm not opposed to breaking changes, I still feel it would be least disruptive to have the async traits in their own (new) module, rather than the sync traits

@lidavidm
Copy link
Member

Or is this just to clean up lib.rs while keeping public import paths the same?

@if0ne
Copy link
Contributor Author

if0ne commented Jan 30, 2026

Clean up lib.rs. I'm re-exporting trais from the sync module

https://github.com/if0ne/arrow-adbc/blob/bf2f871b2b2264dbbb0fcb1fac66c79f1826e431/rust/core/src/lib.rs#L48

@lidavidm
Copy link
Member

lidavidm commented Feb 4, 2026

@felipecrv @eitsupi any concerns?

@eitsupi
Copy link
Contributor

eitsupi commented Feb 4, 2026

There doesn't seem to be any problem with this movement 🚀

@felipecrv
Copy link
Contributor

@felipecrv @eitsupi any concerns?

I would prefer sync to be the default (no namespace), but that is a minority take.

@lidavidm
Copy link
Member

lidavidm commented Feb 5, 2026

@felipecrv @eitsupi any concerns?

I would prefer sync to be the default (no namespace), but that is a minority take.

Right, this doesn't change anything, since the submodule's contents are re-exported. I do think that even when we add async traits, those should not be at the crate root but should be namespaced (and we can keep sync as the default).

@lidavidm lidavidm merged commit 7cc8b6a into apache:main Feb 9, 2026
8 checks passed
@lidavidm lidavidm added this to the ADBC Libraries 23 milestone Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments