Open
Conversation
github-actions
bot
added
parquet
Today, arrow-rs supports Parquet field-IDs via a heuristic based on a special key (`PARQUET:field_id`) in the field metadata. Instead, I would suggest bumping it to a method on Field itself.
Fokko
changed the title
id() as a public function on Fieldid() on Field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
id()as a public function onField#9469.Rationale for this change
I want to discuss the following with the community. Today, arrow-rs supports Parquet field-IDs via a heuristic based on a special key (
PARQUET:field_id) in the field metadata. Instead, I would suggest bumping it to a method on Field itself.What changes are included in this PR?
Adding a public
id(), and removing a privatefield_id(field).Are these changes tested?
Existing tests.
Are there any user-facing changes?
A new public API.