GH-48576: [C++][FlightRPC] ODBC: add Mac setup script #48578

alinaliBQ · 2025-12-17T22:24:41Z

Rationale for this change

#48576

What changes are included in this PR?

Added Mac Setup ODBC ini Script

Are these changes tested?

Script is tested in CI.
Tested locally on macOS.

Are there any user-facing changes?

N/A

GitHub Issue: [C++][FlightSQL][ODBC] macOS ODBC setup ini script #48576

github-actions · 2025-12-17T22:25:05Z

⚠️ GitHub issue #48576 has been automatically assigned in GitHub to PR creator.

alinaliBQ · 2025-12-17T22:25:26Z

@lidavidm This draft PR for macOS ODBC registration set up script is ready for review. It is pending on #48577 to undraft.

lidavidm

Is it possible to guard the scripts with (e.g.) set -euo pipefail?

cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc.sh

lidavidm · 2026-01-05T05:12:13Z

cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc_ini.sh

+odbc_install_script="${source_dir}/install_odbc.sh"
+
+chmod +x "$odbc_install_script"
+. "$odbc_install_script" /Library/Apache/ArrowFlightSQLODBC/lib/libarrow_flight_sql_odbc.dylib


Do we have to source the script?

Thanks for catching it, I think it is not necessary. Removed sourcing of the script.

alinaliBQ

Thanks for the review David, addressed all comments

cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc.sh

alinaliBQ · 2026-01-06T23:13:10Z

cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc_ini.sh

+odbc_install_script="${source_dir}/install_odbc.sh"
+
+chmod +x "$odbc_install_script"
+. "$odbc_install_script" /Library/Apache/ArrowFlightSQLODBC/lib/libarrow_flight_sql_odbc.dylib


Thanks for catching it, I think it is not necessary. Removed sourcing of the script.

alinaliBQ · 2026-01-06T23:15:21Z

Is it possible to guard the scripts with (e.g.) set -euo pipefail?

@lidavidm Yes, I have added the guards at the beginning of scripts.

lidavidm · 2026-01-07T02:45:39Z

cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc.sh

@@ -0,0 +1,78 @@
+#!/bin/sh


Are we using plain sh, or assuming something else (zsh on macOS?)

Good catch and I have changed to use #!/bin/bash. The scripts assume bash shells on macOS are used.

alinaliBQ · 2026-02-10T21:45:39Z

@lidavidm This PR is ready for review! Please have a look

lidavidm · 2026-02-11T00:45:28Z

.github/workflows/cpp_extra.yml

          ci/scripts/cpp_build.sh $(pwd) $(pwd)/build
+      - name: Register Flight SQL ODBC Driver
+        run: |
+          chmod +x cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc.sh


Should the script just be marked executable when checked into git?

Yup. I think the script was already marked executable, I have removed the unneeded chmod +x line

raulcd · 2026-02-11T09:02:32Z

cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc_ini.sh

@@ -0,0 +1,85 @@
+#!/bin/bash


Right now this file isn't used anywhere, is it? Should we add it when we are using it if we plan to follow up with other PRs?

Yes, that's fair. I have removed this file from this PR

* added setup script for mac and platform folders Co-Authored-By: Alina (Xi) Li <alina.li@improving.com> Co-Authored-By: vic-tsang <victor.tsang@improving.com> Update install_odbc.sh

- Moved admin check upwards - removed sourcing of script that isn't required

The scripts assume bash shells on macOS are used.

The scripts are already executable. `chmod +x` should not be needed

alinaliBQ

Addressed comments

alinaliBQ · 2026-02-11T18:48:41Z

.github/workflows/cpp_extra.yml

          ci/scripts/cpp_build.sh $(pwd) $(pwd)/build
+      - name: Register Flight SQL ODBC Driver
+        run: |
+          chmod +x cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc.sh


Yup. I think the script was already marked executable, I have removed the unneeded chmod +x line

github-actions bot added Component: C++ Component: FlightRPC awaiting review Awaiting review labels Dec 17, 2025

lidavidm changed the title ~~GH-48576: [C++][FlightRPC] Mac Setup ODBC ini Script~~ GH-48576: [C++][FlightRPC] ODBC: add Mac setup script Jan 5, 2026

lidavidm reviewed Jan 5, 2026

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jan 5, 2026

lidavidm reviewed Jan 5, 2026

View reviewed changes

alinaliBQ force-pushed the gh-48576-macos-ini-script branch from 3292db5 to c64342b Compare January 6, 2026 23:14

alinaliBQ commented Jan 6, 2026

View reviewed changes

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 6, 2026

lidavidm reviewed Jan 7, 2026

View reviewed changes

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Jan 7, 2026

lidavidm approved these changes Jan 8, 2026

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jan 8, 2026

alinaliBQ force-pushed the gh-48576-macos-ini-script branch from 3d97d65 to 8045be2 Compare February 10, 2026 00:00

github-actions bot added the CI: Extra: C++ Run extra C++ CI label Feb 10, 2026

alinaliBQ force-pushed the gh-48576-macos-ini-script branch from 5c55ed2 to c0c1ce4 Compare February 10, 2026 21:44

alinaliBQ marked this pull request as ready for review February 10, 2026 21:44

alinaliBQ requested review from assignUser, jonkeane and kou as code owners February 10, 2026 21:44

alinaliBQ requested a review from raulcd as a code owner February 10, 2026 21:44

lidavidm approved these changes Feb 11, 2026

View reviewed changes

raulcd reviewed Feb 11, 2026

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Feb 11, 2026

vic-tsang and others added 6 commits February 11, 2026 09:58

Mac Setup ODBC ini Script

fcf0d3c

* added setup script for mac and platform folders Co-Authored-By: Alina (Xi) Li <alina.li@improving.com> Co-Authored-By: vic-tsang <victor.tsang@improving.com> Update install_odbc.sh

Apply suggestions from David

d231254

- Moved admin check upwards - removed sourcing of script that isn't required

Use #!/bin/bash for scripts

b0812fd

The scripts assume bash shells on macOS are used.

Register ODBC on macOS

0aaf41d

Remove chmod +x command

06619c8

The scripts are already executable. `chmod +x` should not be needed

Delete install_odbc_ini.sh

7a0e164

alinaliBQ force-pushed the gh-48576-macos-ini-script branch from c0c1ce4 to 7a0e164 Compare February 11, 2026 18:46

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 11, 2026

alinaliBQ commented Feb 11, 2026

View reviewed changes

GH-48576: [C++][FlightRPC] ODBC: add Mac setup script #48578

Are you sure you want to change the base?

GH-48576: [C++][FlightRPC] ODBC: add Mac setup script #48578

Conversation

alinaliBQ commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

alinaliBQ commented Dec 17, 2025

Uh oh!

lidavidm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ commented Jan 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ commented Feb 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alinaliBQ commented Dec 17, 2025 •

edited

Loading