GH-49103: [Python] Add internal type system stubs (_types, error, _stubs_typing) #48622
+1,289
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Python
Component: Documentation
awaiting committer review
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
from
d3c5740 to
27d1c65
Compare
Member
Author
|
I've rebased this on the annotation infra check PR (#48618) to make sure we're on the right track. |
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
2 times, most recently
from
3f9ed3b to
0ac95b0
Compare
rok
changed the title
|
|
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
2 times, most recently
from
4daf6ed to
7873930
Compare
rok
force-pushed
the
pyarrow-stubs-pr2-core-types
branch
from
7873930 to
43e7cc6
Compare
Co-authored-by: Dan Redding <125183946+dangotbanned@users.noreply.github.com>
rok
requested review from
AlenkaF,
assignUser,
jonkeane,
kou and
raulcd
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is the second in series of PRs adding type annotations to pyarrow and resolving #32609. It builds on top of and should be merged after #48618.
What changes are included in this PR?
This adds:
_types.pyi- Core type definitions including_stubs_typing.pyi- Internal typing protocols and helpers used across stub fileserror.pyi- Exception classes (ArrowException,ArrowInvalid,ArrowIOError, etc.)lib.pyi,io.pyi,scalar.pyi- using__getattr__to allow imports to resolve while deferring to subsequent PRsAre these changes tested?
Via CI type checks established in #48618.
Are there any user-facing changes?
Users will start seeing some minimal annotated types.