-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-49081: [C++][Parquet][FOLLOWUP] Correct variant's extension name #49211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@WillAyd Current CI does not check whether code can be compiled by meson successfully. Do we need to add a CI to check this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates Meson build definitions in the C++ Parquet/Arrow codebase to reflect a previous file move/rename related to the Parquet Variant extension, fixing Meson build breakage.
Changes:
- Remove the outdated
arrow/variant_internal.ccentry from Parquet’s Meson source list. - Add
extension/parquet_variant.ccto Arrow’s Meson source list so the moved implementation is compiled into Arrow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cpp/src/parquet/meson.build | Drops a source file entry that no longer exists/was moved, preventing Meson build errors. |
| cpp/src/arrow/meson.build | Adds the new Parquet Variant extension implementation source to Arrow’s build sources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4b69c86 to
dc4c0fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dc4c0fb to
4520d23
Compare
4520d23 to
299ca9e
Compare
wgtmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
For Meson to run the C++ Extra tag has to be used |
Rationale for this change
Previous PR moved one file, modified the CMakeLists but didn't modify the meson file. Fix meson build failure.
What changes are included in this PR?
Modified the meson configuration files.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.