Skip to content

Conversation

@HuaHuaY
Copy link
Contributor

@HuaHuaY HuaHuaY commented Feb 10, 2026

Rationale for this change

Previous PR moved one file, modified the CMakeLists but didn't modify the meson file. Fix meson build failure.

What changes are included in this PR?

Modified the meson configuration files.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copilot AI review requested due to automatic review settings February 10, 2026 04:04
@HuaHuaY HuaHuaY requested a review from wgtmac as a code owner February 10, 2026 04:04
@github-actions github-actions bot added the awaiting review Awaiting review label Feb 10, 2026
@HuaHuaY
Copy link
Contributor Author

HuaHuaY commented Feb 10, 2026

@WillAyd Current CI does not check whether code can be compiled by meson successfully. Do we need to add a CI to check this?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Meson build definitions in the C++ Parquet/Arrow codebase to reflect a previous file move/rename related to the Parquet Variant extension, fixing Meson build breakage.

Changes:

  • Remove the outdated arrow/variant_internal.cc entry from Parquet’s Meson source list.
  • Add extension/parquet_variant.cc to Arrow’s Meson source list so the moved implementation is compiled into Arrow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
cpp/src/parquet/meson.build Drops a source file entry that no longer exists/was moved, preventing Meson build errors.
cpp/src/arrow/meson.build Adds the new Parquet Variant extension implementation source to Arrow’s build sources.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Feb 10, 2026
@wgtmac wgtmac merged commit a6b45b6 into apache:main Feb 10, 2026
54 of 55 checks passed
@wgtmac wgtmac removed the awaiting committer review Awaiting committer review label Feb 10, 2026
@HuaHuaY HuaHuaY deleted the fix_issue_49081 branch February 10, 2026 09:12
@WillAyd
Copy link
Contributor

WillAyd commented Feb 10, 2026

@WillAyd Current CI does not check whether code can be compiled by meson successfully. Do we need to add a CI to check this?

For Meson to run the C++ Extra tag has to be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants