GH-49217: [C++][Parquet] Fix map type to preserve key-value metadata #49218
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
Author
|
Could you help review this? @pitrou @adamreeve @mapleFU |
mapleFU
reviewed
Feb 11, 2026
| case ::arrow::Type::MAP: | ||
| if (origin_type.id() == ::arrow::Type::MAP) { | ||
| const bool keys_sorted = | ||
| checked_cast<const ::arrow::MapType&>(origin_type).keys_sorted(); |
Member
There was a problem hiding this comment.
According to MapToSchemaField, is keys_sorted always false?
Member
Author
There was a problem hiding this comment.
Yes, that's why I made it sorted in this test case.
mapleFU
approved these changes
Feb 11, 2026
Member
mapleFU
left a comment
mapleFU
left a comment
There was a problem hiding this comment.
Hard to believe it doesn't have mapping...
github-actions
bot
added
awaiting committer review
HuaHuaY
approved these changes
Feb 11, 2026
pitrou
reviewed
Feb 11, 2026
| restored_schema->field(0)->type()); | ||
| ASSERT_EQ(GetFieldId(*restored_schema->field(0)), 99); | ||
|
|
||
| ASSERT_TRUE(restored_map->keys_sorted()); |
Member
There was a problem hiding this comment.
Can we just call AssertTypeEqual(*sorted_map, *restored_map, /*check_metadata=*/true);?
It doesn't seem useful to spelunk the nested type hierarchy manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Previously, when converting Parquet schemas back to Arrow schemas with serialized ARROW:schema metadata, the key-value metadata on map nested fields (key/value fields) was lost. The GetNestedFactory() function lacked a MAP case, preventing ApplyOriginalStorageMetadata from recursively restoring metadata to map children. This fix adds MAP support to the factory function, enabling proper metadata preservation for maps during schema roundtrips.
What changes are included in this PR?
Added a MAP case to GetNestedFactory() that returns a lambda to reconstruct MapType while preserving the keys_sorted property from the original type.
Are these changes tested?
Yes. Added a test case to verify the issue has been fixed.
Are there any user-facing changes?
No.