Skip to content

GH-49522: [CI] Update chrome_version for emscripten job to latest stable (v146) #49523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
raulcd wants to merge 5 commits into
base: main
Choose a base branch
from
+10 −6
Draft

GH-49522: [CI] Update chrome_version for emscripten job to latest stable (v146) #49523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4158e6
GH-49522: [CI] Update chrome_version for emscripten job to latest sta…
raulcd Mar 16, 2026
e2ca39e
Try upgrading to a newer selenium version to be compatible with new c…
raulcd Mar 16, 2026
e5e292f
Add some more logging
raulcd Mar 17, 2026
161a055
Try increasing timeout (it works locally but times out on CI)
raulcd Mar 17, 2026
983d8c3
Try increasing default timeout
raulcd Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/docker/conda-python-emscripten.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ ARG arch
ARG python="3.12"
FROM ${repo}:${arch}-conda-python-${python}

ARG selenium_version="4.15.2"
ARG selenium_version="4.41.0"
ARG pyodide_version="0.26.0"
ARG chrome_version="latest"
ARG required_python_min="(3,12)"
Expand Down
4 changes: 2 additions & 2 deletions compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,8 +948,8 @@ services:
clang_tools: ${CLANG_TOOLS}
llvm: ${LLVM}
pyodide_version: "0.26.0"
chrome_version: "134"
selenium_version: "4.15.2"
chrome_version: "146"
selenium_version: "4.41.0"
required_python_min: "(3,12)"
python: ${PYTHON}
shm_size: *shm-size
Expand Down
10 changes: 7 additions & 3 deletions python/scripts/run_emscripten_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@

class TemplateOverrider(http.server.SimpleHTTPRequestHandler):
def log_request(self, code="-", size="-"):
# don't log successful requests
# don't log successful requests but log errors
if isinstance(code, int) and code >= 400:
sys.stderr.write(f"HTTP {code} for {self.path}\n")
return

def do_GET(self) -> bytes | None:
Expand Down Expand Up @@ -200,7 +202,7 @@ class BrowserDriver:
def __init__(self, hostname, port, driver):
self.driver = driver
self.driver.get(f"http://{hostname}:{port}/test.html")
self.driver.set_script_timeout(100)
self.driver.set_script_timeout(300)

def load_pyodide(self, dist_dir):
pass
Expand Down Expand Up @@ -259,7 +261,9 @@ def __init__(self, hostname, port):
options = Options()
options.add_argument("--headless")
options.add_argument("--no-sandbox")
super().__init__(hostname, port, webdriver.Chrome(options=options))
driver = webdriver.Chrome(options=options)
driver.command_executor._client_config.timeout = 300
super().__init__(hostname, port, driver)


class FirefoxDriver(BrowserDriver):
Expand Down
Loading