AVRO-4202: Refer to fields for generated hashCode

[steven-aerts]

The generated hashCode function has a local parameter called result. To prevent this local variable to conflict with field which have the same name, it has to refer to the fields with this.<fieldName> making it unambiguous refer to fields and not local variables.

What is the purpose of the change

Fix a name collision in the generated hashCode function reported in AVRO-4202

Verifying this change

This change is a trivial rework I also manually verified. Let me know if you want an extra test.

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[RyanSkraba]

Thanks so much for this fix! It should be included in the next minor release.
Cherry-picked to branch-1.12.

Let me know if you want me to assign you this JIRA! I've marked it as Resolved, but I didn't find an account for you.

[steven-aerts]

@RyanSkraba thanks a lot for cherry picking.
My apache account is steven.aerts. I cannot assign it to myself anymore as its state is Resolved. Do not worry for me it is okay as it is.

[ratajka]

Thanks so much for this fix! It should be included in the next minor release. Cherry-picked to branch-1.12.

Let me know if you want me to assign you this JIRA! I've marked it as Resolved, but I didn't find an account for you.

Hi @RyanSkraba,
When are you planning the next minor release, included this PR?

Thanks in advance!

[psantanamrv1]

Hello @martin-g @RyanSkraba following @ratajka comment, do you any predictions on release the 1.12.1 or 1.13.0? I see the release cycle being one year and wanted to have an expectation on when to expect.

Thank you

[martin-g]

No idea!