-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AVRO-4232: [Python] Modernize the Python tooling #3658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6ec71fe
9902208
d81a4a7
a411989
9a2ff4e
34eae25
a427cfb
d401b80
9e71d4b
d73daa5
cb2b731
7023260
7ff957b
f246a65
cdedb56
78f3a5c
e462824
e0484b3
3c7c8c7
aeb32b9
c15c680
4724e89
91747aa
712fde3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -322,7 +322,7 @@ def respond(self, call_request): | |
| else: | ||
| writers_schema = local_message.errors | ||
| self.write_error(writers_schema, error, buffer_encoder) | ||
| except schema.AvroException as e: | ||
| except avro.errors.AvroException as e: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi. This MR not only modernize the python tooling. But also fix that bug. Do you plane to update the library in pypi too? Thanks a lot.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right! It will be part of the 1.13.0 release but I cannot say when it will be made. |
||
| error = avro.errors.AvroRemoteException(str(e)) | ||
| buffer_encoder = avro.io.BinaryEncoder(io.BytesIO()) | ||
| META_WRITER.write(response_metadata, buffer_encoder) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,11 +32,18 @@ | |
| { | ||
| "name": "Message", | ||
| "type": "record", | ||
| "fields": [{"name": "to", "type": "string"}, {"name": "from", "type": "string"}, {"name": "body", "type": "string"}], | ||
| "fields": [ | ||
| {"name": "to", "type": "string"}, | ||
| {"name": "from", "type": "string"}, | ||
| {"name": "body", "type": "string"}, | ||
| ], | ||
| } | ||
| ], | ||
| "messages": { | ||
| "send": {"request": [{"name": "message", "type": "Message"}], "response": "string"}, | ||
| "send": { | ||
| "request": [{"name": "message", "type": "Message"}], | ||
| "response": "string", | ||
| }, | ||
| "replay": {"request": [], "response": "string"}, | ||
| }, | ||
| } | ||
|
|
@@ -71,7 +78,7 @@ def do_POST(self) -> None: | |
|
|
||
|
|
||
| def main(): | ||
| mail_server = http_server.HTTPServer(SERVER_ADDRESS, MailHandler) | ||
| mail_server = http.server.HTTPServer(SERVER_ADDRESS, MailHandler) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have no idea how this worked before
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably didn't. Is there evidence it was ever covered? |
||
| mail_server.allow_reuse_address = True | ||
| mail_server.serve_forever() | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.