[Java] Optimize beam pubsub message to serialized pubsub protobuf message#37896
[Java] Optimize beam pubsub message to serialized pubsub protobuf message#37896scwhittle wants to merge 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the performance of serializing Beam PubsubMessage objects into Google Cloud Pub/Sub protobuf messages. It introduces optimizations to reduce overhead, particularly for messages consisting solely of a payload, by directly serializing the payload to a byte array. For messages with additional fields, it refines the protobuf builder usage to avoid setting empty or null values, contributing to more efficient message construction and overall improved serialization speed. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
ab7ee1a to
f9a0cb1
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
f9a0cb1 to
d1cad03
Compare
For the common case where just the payload is set, we can just copy directly to a byte array.
For the case where there are other set fields, we optimize protobuf construction by not calling methods on the builder for empty attribute map or empty strings.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.