[[BP-62] Expose batchReadUnconfirmedAsync to ReadHandle#4739
Open
dao-jun wants to merge 2 commits intoapache:masterfrom
Open
[[BP-62] Expose batchReadUnconfirmedAsync to ReadHandle#4739dao-jun wants to merge 2 commits intoapache:masterfrom
dao-jun wants to merge 2 commits intoapache:masterfrom
Conversation
eolivelli
requested changes
Apr 9, 2026
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
Overall the code change looks good
Please add unit tests about error scenarios (input validations, internal errors....)
errors must be reported accurately in the CompletableFuture
Also test the fallback case where batch reads are not available
Member
Author
|
@hangc0276 @lhotari @zymap PTAL |
eolivelli
approved these changes
Apr 13, 2026
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
Patch looks good to me, as far as CI passes.
I have restarted the failed jobs
Member
Author
|
/bkbot rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a supplement to BP62
Motivation
batchReadUnconfirmedAsyncdoesn't exposed to ReadHandle now, downstream projects maybe depend on the method.Changes