Skip to content

[[BP-62] Expose batchReadUnconfirmedAsync to ReadHandle#4739

Open
dao-jun wants to merge 2 commits intoapache:masterfrom
dao-jun:dev/expose_batchread_unconfirmed
Open

[[BP-62] Expose batchReadUnconfirmedAsync to ReadHandle#4739
dao-jun wants to merge 2 commits intoapache:masterfrom
dao-jun:dev/expose_batchread_unconfirmed

Conversation

@dao-jun
Copy link
Copy Markdown
Member

@dao-jun dao-jun commented Apr 6, 2026

This is a supplement to BP62

Motivation

batchReadUnconfirmedAsync doesn't exposed to ReadHandle now, downstream projects maybe depend on the method.

Changes

  1. Expose batchReadUnconfirmedAsync to ReadHandle
  2. Add tests

In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@dao-jun dao-jun changed the title Expose batchReadUnconfirmedAsync to ReadHandle [[BP-62] Expose batchReadUnconfirmedAsync to ReadHandle Apr 6, 2026
Copy link
Copy Markdown
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code change looks good

Please add unit tests about error scenarios (input validations, internal errors....)
errors must be reported accurately in the CompletableFuture

Also test the fallback case where batch reads are not available

@dao-jun dao-jun closed this Apr 9, 2026
@dao-jun dao-jun reopened this Apr 9, 2026
@dao-jun dao-jun requested a review from eolivelli April 9, 2026 14:41
@dao-jun
Copy link
Copy Markdown
Member Author

dao-jun commented Apr 10, 2026

@hangc0276 @lhotari @zymap PTAL

Copy link
Copy Markdown
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me, as far as CI passes.
I have restarted the failed jobs

@dao-jun
Copy link
Copy Markdown
Member Author

dao-jun commented Apr 15, 2026

/bkbot rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants