Update Nginx config file generator and add support for connection upgrade#56
Update Nginx config file generator and add support for connection upgrade#56grkvlt wants to merge 1 commit intoapache:masterfrom
Conversation
a537e94 to
18ace8c
Compare
|
@grkvlt what tests should we run to confirm that this hasn't broken previous use-cases, and that it now supports the use-case that motivated you to make this change? |
18ace8c to
b2b69b7
Compare
|
@aledsage the existing Nginx tests are sufficient to verify there are no regressions, however the original use-case for this code is no longer as urgent. It is still a useful change, since it supports HTTP 1.1 and connection upgrades properly now, and the code is also more readable. The change to the config file that adds this is the addition of these two groups of lines: |
b2b69b7 to
afbb285
Compare
|
@grkvlt the |
|
@grkvlt Can you take a look at this please to see if it is still relevant, and address the comments above if appropriate Thanks |
|
Refer to this link for build results (access rights to CI server needed): |
|
P.S. Can you also rebase if this is still valid |
Adds support for HTTP 1.1 and connection upgrades, as well as improving formatting and better use of the
StringBuilderThe fix for the NPE when no SSL config is provided has now been merged as #59