Skip to content

[CALCITE-7413] Add Concat and Substring function (enabled in Mongodb library) #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
Feb 12, 2026
Merged

[CALCITE-7413] Add Concat and Substring function (enabled in Mongodb library) #4790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mongodb/src/main/java/org/apache/calcite/adapter/mongodb/MongoRules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ static class RexToMongoTranslator extends RexVisitorImpl<String> {
MONGO_OPERATORS.put(SqlStdOperatorTable.LESS_THAN, "$lt");
MONGO_OPERATORS.put(SqlStdOperatorTable.LESS_THAN_OR_EQUAL, "$lte");
MONGO_OPERATORS.put(SqlStdOperatorTable.ABS, "$abs");
MONGO_OPERATORS.put(SqlStdOperatorTable.CONCAT, "$concat");
MONGO_OPERATORS.put(SqlStdOperatorTable.SUBSTRING, "$substrCP");
}

protected RexToMongoTranslator(JavaTypeFactory typeFactory,
Expand Down
85 changes: 85 additions & 0 deletions mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoAdapterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,4 +1093,89 @@ private static Consumer<List> mongoChecker(final String... expected) {
"POP_A=17522",
"POP_A=22576");
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-7413">[CALCITE-7413]
* Add Concat and Substring function (enabled in Mongodb library)</a>. */
@Test void testConcat() {
Copy link
Copy Markdown
Contributor

@mihaibudiu mihaibudiu Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about Mongo to validate these, I assume you have checked that they work.

assertModel(MODEL)
.query("SELECT city || ' ' || state from zips"
+ " order by pop")
.limit(3)
.queryContains(
mongoChecker(
"{$project: {EXPR$0:{$concat:[{$concat:['$city',{$literal: ' '}]},'$state']},POP:'$pop'}}",
"{$sort:{POP:1}}"))
.returnsOrdered("EXPR$0=PENTAGON DC",
"EXPR$0=BRATTLEBORO VT",
"EXPR$0=RUTLAND VT");
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-7413">[CALCITE-7413]
* Add Concat and Substring function (enabled in Mongodb library)</a>. */
@Test void testAliasNameConcat() {
assertModel(MODEL)
.query("SELECT city || ' ' || state AS full_name from zips"
+ " order by pop")
.limit(3)
.queryContains(
mongoChecker(
"{$project: {FULL_NAME:{$concat:[{$concat:['$city',{$literal: ' '}]},'$state']},POP:'$pop'}}",
"{$sort:{POP:1}}"))
.returnsOrdered("FULL_NAME=PENTAGON DC",
"FULL_NAME=BRATTLEBORO VT",
"FULL_NAME=RUTLAND VT");
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-7413">[CALCITE-7413]
* Add Concat and Substring function (enabled in Mongodb library)</a>. */
@Test void testAliasNameMultipleConcat() {
assertModel(MODEL)
.query("SELECT city || ',' || ',' || state AS full_name from zips"
+ " order by pop")
.limit(3)
.queryContains(
mongoChecker(
"{$project:{FULL_NAME:{$concat:[{$concat:[{$concat:['$city',{$literal:','}]},{$literal:','}]},'$state']},POP:'$pop'}}",
"{$sort:{POP:1}}"))
.returnsOrdered("FULL_NAME=PENTAGON,,DC",
"FULL_NAME=BRATTLEBORO,,VT",
"FULL_NAME=RUTLAND,,VT");
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-7413">[CALCITE-7413]
* Add Concat and Substring function (enabled in Mongodb library)</a>. */
@Test void testSubstring() {
assertModel(MODEL)
.query("SELECT SUBSTRING(city FROM 1 FOR 2) from zips"
+ " order by pop")
.limit(3)
.queryContains(
mongoChecker(
"{$project:{EXPR$0:{$substrCP:['$city',{$literal:1},{$literal:2}]},POP:'$pop'}}",
"{$sort:{POP:1}}"))
.returnsOrdered("EXPR$0=EN",
"EXPR$0=RA",
"EXPR$0=UT");
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-7413">[CALCITE-7413]
* Add Concat and Substring function (enabled in Mongodb library)</a>. */
@Test void testAliasNameSubstring() {
assertModel(MODEL)
.query("SELECT SUBSTRING(city FROM 1 FOR 2) AS city_substring from zips"
+ " order by pop")
.limit(3)
.queryContains(
mongoChecker(
"{$project:{CITY_SUBSTRING:{$substrCP:['$city',{$literal:1},{$literal:2}]},POP:'$pop'}}",
"{$sort:{POP:1}}"))
.returnsOrdered("CITY_SUBSTRING=EN",
"CITY_SUBSTRING=RA",
"CITY_SUBSTRING=UT");
}
}
Loading