[CALCITE-7347] UNKNOWN type inferred for array element type#4800
Merged
mihaibudiu merged 1 commit intoapache:mainfrom Feb 18, 2026
Merged
[CALCITE-7347] UNKNOWN type inferred for array element type#4800mihaibudiu merged 1 commit intoapache:mainfrom
mihaibudiu merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
xiedeyantu
approved these changes
Feb 18, 2026
asolimando
reviewed
Feb 18, 2026
|
|
||
| final SqlTypeName typeName = type.getSqlTypeName(); | ||
| if (typeName == SqlTypeName.NULL) { | ||
| if (typeName == SqlTypeName.NULL || typeName == SqlTypeName.UNKNOWN) { |
Member
There was a problem hiding this comment.
I was going to suggest that this reminded me of typing rules for NULL, and it makes total sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is really in considering the least restrictive type of
(UNKNOWN, T)asTinstead ofUNKNOWN.I think this is a very sensible choice.