Fix virtual threads optimized test for Spring Boot 4.0.4#1732
Merged
Conversation
… 4.0.4 Spring Boot 4.0.4's TaskExecutionAutoConfiguration uses @ConditionalOnMissingBean(Executor.class) when auto-configuring the SimpleAsyncTaskExecutor for virtual threads. When another Executor bean is registered first (e.g. by Spring Security auto-configuration), the auto-config backs off and no SimpleAsyncTaskExecutor is created, causing the test assertion to fail. Explicitly define a SimpleAsyncTaskExecutor bean in the test's TestConfiguration using SimpleAsyncTaskExecutorBuilder, matching the approach used by the passing SpringBootPlatformHttpMultipleExecutorsVirtualThreadsTest. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
oscerd
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpringBootPlatformHttpVirtualThreadsOptimizedTest.testVirtualThreadExecutorIsPreferredwhich fails because Spring Boot 4.0.4'sTaskExecutionAutoConfigurationuses@ConditionalOnMissingBean(Executor.class)when auto-configuringSimpleAsyncTaskExecutorfor virtual threads. When anotherExecutorbean is registered first (e.g. by Spring Security auto-configuration), the auto-config backs off and noSimpleAsyncTaskExecutoris created.SimpleAsyncTaskExecutorbean in the test'sTestConfigurationusingSimpleAsyncTaskExecutorBuilder, matching the approach used by the passingSpringBootPlatformHttpMultipleExecutorsVirtualThreadsTest.Test plan
SpringBootPlatformHttpVirtualThreadsOptimizedTest.testVirtualThreadExecutorIsPreferredpassesSpringBootPlatformHttpMultipleExecutorsVirtualThreadsTest,SpringBootPlatformHttpVirtualThreadsTest) still pass🤖 Generated with Claude Code on behalf of Federico Mariani