CASSSIDECAR-409 Adding gossip based safety check to Live Migration data copy task endpoint#321
Open
nvharikrishna wants to merge 2 commits intoapache:trunkfrom
Open
Conversation
nvharikrishna
force-pushed
the
409-lm-data-copy-safety-check-trunk
branch
from
5709a4b to
4a5daf8
Compare
frankgh
reviewed
Mar 8, 2026
Contributor
frankgh
left a comment
frankgh
left a comment
There was a problem hiding this comment.
Looks good so far. I have a few minor comments.
| */ | ||
| private Future<Void> verifyCassandraNotRunning(InstanceMetadata localInstance) | ||
| { | ||
| return executorPools.internal().executeBlocking(() -> { |
Contributor
There was a problem hiding this comment.
this does not need to run on a blocking method. There's no IO happening here. The check is an in-memory check. Which brings the question about whether you want to do an online check here instead of relying on a cached value?
| private GossipInfoResponse.GossipInfo findGossipInfo(GossipInfoResponse gossipResponse, | ||
| String instance) throws UnknownHostException | ||
| { | ||
| InstanceMetadata metadata = instancesMetadata.instanceFromHost(instance); |
Contributor
There was a problem hiding this comment.
is this instance managed by the local sidecar? instancesMetadata is only available for instances managed by the local Sidecar process.
| + ". It must be greater than zero when specified."); | ||
| } | ||
|
|
||
| if (gossipFetchMaxRetries != null && gossipFetchMaxRetries <= 0) |
Contributor
There was a problem hiding this comment.
should we also have some guardrails around an upperbound here? I'm thinking from a point of view of a malicious payload that can make the service retry for a long time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making this change as part of CEP-40.
CASSSIDECAR-409 Add gossip-based safety checks to Live Migration data copy endpoint
Summary of changes: