Skip to content

ninja-fix: Remove SSTable format randomization and related dead code for CASSANDRA-21177#4672

Open
shruti-p-s wants to merge 1 commit intoapache:cassandra-5.0from
shruti-p-s:CASSANDRA-21177-5.0
Open

ninja-fix: Remove SSTable format randomization and related dead code for CASSANDRA-21177#4672
shruti-p-s wants to merge 1 commit intoapache:cassandra-5.0from
shruti-p-s:CASSANDRA-21177-5.0

Conversation

@shruti-p-s
Copy link
Contributor

@shruti-p-s shruti-p-s commented Mar 13, 2026 •
edited
Loading

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

frankgh
frankgh reviewed Mar 13, 2026
View reviewed changes
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
SNAPSHOT_MIN_ALLOWED_TTL_SECONDS("cassandra.snapshot.min_allowed_ttl_seconds", "60"),
SSL_ENABLE("ssl.enable"),
SSL_STORAGE_PORT("cassandra.ssl_storage_port"),
SSTABLE_FORMAT_DEFAULT("cassandra.sstable.format.default"),
Copy link
Contributor

@frankgh frankgh Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is only used from test/simulator/main/org/apache/cassandra/simulator/ClusterSimulation.java

@maedhroz
Copy link
Contributor

maedhroz commented Mar 16, 2026

+1

@shruti-p-s shruti-p-s changed the title ninja-fix: Fix SSTable format randomization using config instead of d… ninja-fix: Remove SSTable format randomization and related dead code Mar 25, 2026
@shruti-p-s shruti-p-s changed the title ninja-fix: Remove SSTable format randomization and related dead code ninja-fix: Remove SSTable format randomization and related dead code for CASSANDRA-21177 Mar 25, 2026
@shruti-p-s shruti-p-s marked this pull request as ready for review March 25, 2026 20:08
@shruti-p-s shruti-p-s force-pushed the CASSANDRA-21177-5.0 branch from b1b9985 to 3bfc0e8 Compare March 25, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankgh frankgh frankgh left review comments

@maedhroz maedhroz maedhroz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shruti-p-s @maedhroz @frankgh