output: allow filtering and honour output format for non-list apis#164
Merged
DaanHoogland merged 4 commits intoapache:mainfrom Aug 8, 2025
Merged
output: allow filtering and honour output format for non-list apis#164DaanHoogland merged 4 commits intoapache:mainfrom
DaanHoogland merged 4 commits intoapache:mainfrom
Conversation
Currently, filtering is not working when the response object is not returning an array. This PR makes changes to allow filtering when response object is an array or a map. For async apis, filter arg is passed to the query request allowing filtering to work with the final response. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr
approved these changes
Aug 5, 2025
Contributor
|
tested destroy Also tried to merge it with #163 but couldn’t get that to work yet. Both look good in isolation. |
DaanHoogland
approved these changes
Aug 5, 2025
Contributor
|
retested: |
|
✅ Build complete for PR #164. 🔗 Download the cmk binaries (expires on August 18, 2025) |
Contributor
|
@shwstppr , any reason not to merge this yet? |
Contributor
Author
|
@DaanHoogland when I checked last it had the need-testing label so I was not sure if you wanted more testing on it |
Contributor
|
right, removed, merging |
shwstppr
added a commit
to shwstppr/cloudstack-cloudmonkey
that referenced
this pull request
Aug 13, 2025
…pache#164) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117
Fixes #152
Currently, filtering is not working when the response object is not returning an array. This PR makes changes to allow filtering when response object is an array or a map.
For async apis, filter arg is passed to the query request allowing filtering to work with the final response.
Output with changes,
For output,