Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 32 commits into
base: main
Choose a base branch
from
+4,581 −174

add support to migrate to and from clvm to nfs

01aa259
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

add support to migrate to and from clvm to nfs
01aa259
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 19, 2026 in 5m 42s

Quality Gate failed

Failed conditions
1 Security Hotspot
8.5% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 30 in core/src/main/java/com/cloud/agent/api/PostMigrationCommand.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Override the "equals" method in this class. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxtJVhTJejGTVrNgEqA&open=AZxtJVhTJejGTVrNgEqA&pullRequest=12617

Check warning on line 1242 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YY_4256DVCsFLrK&open=AZz35YY_4256DVCsFLrK&pullRequest=12617

Check warning on line 431 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrZ&open=AZz35YeN4256DVCsFLrZ&pullRequest=12617

Check warning on line 1142 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35Yk94256DVCsFLrq&open=AZz35Yk94256DVCsFLrq&pullRequest=12617

Check warning on line 2751 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0H7qRYrpT77nGx4twU&open=AZ0H7qRYrpT77nGx4twU&pullRequest=12617

Check warning on line 1630 in server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 89 to 64, Complexity from 20 to 14, Nesting Level from 4 to 2, Number of Variables from 21 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTRR331ZRqy8rtii&open=AZycJTRR331ZRqy8rtii&pullRequest=12617

Check failure on line 2961 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZ5Qi8wmAtCWzk9u&open=AZxykZ5Qi8wmAtCWzk9u&pullRequest=12617

Check warning on line 1134 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YY_4256DVCsFLrF&open=AZz35YY_4256DVCsFLrF&pullRequest=12617

Check warning on line 61 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifyStoragePoolCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "Map.containsKey()" with a call to "Map.computeIfAbsent()". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZyLLxaXyspAfen4iU0S&open=AZyLLxaXyspAfen4iU0S&pullRequest=12617

Check warning on line 1493 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 101 to 64, Complexity from 39 to 14, Nesting Level from 4 to 2, Number of Variables from 29 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTTp331ZRqy8rtin&open=AZycJTTp331ZRqy8rtin&pullRequest=12617

Check failure on line 469 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZySVt7WZWnQmdcHvGAu&open=AZySVt7WZWnQmdcHvGAu&pullRequest=12617

Check warning on line 1049 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\\D' instead of '[^0-9]'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvmG&open=AZxEJ4RLTdhpX5MPbvmG&pullRequest=12617

Check warning on line 129 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPrepareForMigrationCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxtJVlFJejGTVrNgEqC&open=AZxtJVlFJejGTVrNgEqC&pullRequest=12617

Check failure on line 947 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--unbuffered" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrT&open=AZz35YeN4256DVCsFLrT&pullRequest=12617

Check warning on line 373 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTTp331ZRqy8rtij&open=AZycJTTp331ZRqy8rtij&pullRequest=12617

Check failure on line 2132 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "null answer returned" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz4pqxYEjiWGn0xPnaU&open=AZz4pqxYEjiWGn0xPnaU&pullRequest=12617

Check warning on line 1982 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxOattGxHcHLzahI__w&open=AZxOattGxHcHLzahI__w&pullRequest=12617

Check warning on line 1238 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YY_4256DVCsFLrJ&open=AZz35YY_4256DVCsFLrJ&pullRequest=12617

Check failure on line 1313 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJS_0331ZRqy8rtiY&open=AZycJS_0331ZRqy8rtiY&pullRequest=12617

Check failure on line 2596 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZ5Qi8wmAtCWzk9s&open=AZxykZ5Qi8wmAtCWzk9s&pullRequest=12617

Check failure on line 2982 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxOattGxHcHLzahJAAA&open=AZxOattGxHcHLzahJAAA&pullRequest=12617

Check failure on line 34 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtClvmLockTransferCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"logger" is the name of a field in "CommandWrapper". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZwWi8wmAtCWzk9o&open=AZxykZwWi8wmAtCWzk9o&pullRequest=12617

Check warning on line 7189 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "details" which hides the field declared at line 260. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZyLLxjoyspAfen4iU0T&open=AZyLLxjoyspAfen4iU0T&pullRequest=12617

Check warning on line 2265 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz4pqxXEjiWGn0xPnaS&open=AZz4pqxXEjiWGn0xPnaS&pullRequest=12617

Check warning on line 813 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrb&open=AZz35YeN4256DVCsFLrb&pullRequest=12617
View more details on SonarQubeCloud