Fix project-based network filtering in unmanaged instance import#12854
Open
dheeraj12347 wants to merge 10 commits intoapache:mainfrom
Open
Fix project-based network filtering in unmanaged instance import#12854dheeraj12347 wants to merge 10 commits intoapache:mainfrom
dheeraj12347 wants to merge 10 commits intoapache:mainfrom
Conversation
…tatistics table in account_view for netstats (apache#12631)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
…listing for cross-domain deployments (apache#12775)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12854 +/- ##
============================================
+ Coverage 17.61% 18.02% +0.41%
- Complexity 15665 16451 +786
============================================
Files 5917 5968 +51
Lines 531400 537120 +5720
Branches 64970 65966 +996
============================================
+ Hits 93603 96818 +3215
- Misses 427244 429379 +2135
- Partials 10553 10923 +370
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing unmanaged instances for a project, the UI should list only project networks in the network selection; currently account-level networks are also shown, causing the “no matching network” behavior described in the issue.
This change wires the project context into the multi-network selector so that the networks list respects the chosen project.
Implementation details
src/views/compute/wizard/MultiNetworkSelection.vue
Added a projectid prop and passed it through to the listNetworks API call parameters so that networks are filtered by the selected project when present.
src/views/tools/ImportUnmanagedInstance.vue
Passed form.projectid into via the new :projectid prop so that project selection is honored in the unmanaged instance import flow.
Testing
npm run lint
Passes; both modified Vue files were auto-fixed by the linter.
Backend / UI run attempts (blocked):
mvn -Pdeveloper -Dsimulator -DskipTests clean install fails in cloud-engine-schema at systemvm-template-metadata, so the simulator environment could not be fully built locally.
npm run serve on the current branch fails in DomainActionForm.vue with a “content” error, so the import unmanaged instance UI flow could not be exercised end-to-end.