Hide inactive offerings from User type accounts#12865
Open
erikbocks wants to merge 1 commit intoapache:mainfrom
Open
Hide inactive offerings from User type accounts#12865erikbocks wants to merge 1 commit intoapache:mainfrom
erikbocks wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12865 +/- ##
=========================================
Coverage 18.02% 18.02%
- Complexity 16450 16451 +1
=========================================
Files 5968 5968
Lines 537086 537088 +2
Branches 65961 65961
=========================================
+ Hits 96819 96820 +1
- Misses 429347 429348 +1
Partials 10920 10920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the compute offerings tab behavior to prevent the listing of inactive offerings to User type accounts.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
Logged in as the ROOT admin, I validated that the compute offerings' listing displayed the filter button, and allowed the listing of
ActiveandInactiveofferings. Then, I logged in with aUsertype account, and validated that the state filter button was hidden, and onlyActiveofferings were listed.