api, server, ui: allow host auto-select for migrateVirtualMachineWith… by shwstppr · Pull Request #6785 · apache/cloudstack

shwstppr · 2022-09-29T20:29:06Z

Description

Fixes #6773

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

…Volume Fixes apache#6773 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

acs-robot · 2022-09-29T20:30:24Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

blueorangutan · 2022-09-29T20:31:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

acs-robot · 2022-09-29T20:32:02Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-09-29T20:33:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-09-29T20:36:35Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6785 (SL-JID-2442)

blueorangutan · 2022-09-29T20:38:14Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6785 (SL-JID-2443)

sonarqubecloud · 2022-09-29T21:39:04Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication

codecov · 2022-09-29T23:42:52Z

Codecov Report

Merging #6785 (919c4e6) into main (c9b103c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #6785      +/-   ##
============================================
- Coverage     12.95%   12.95%   -0.01%     
  Complexity     8986     8986              
============================================
  Files          2728     2728              
  Lines        256647   256656       +9     
  Branches      40024    40026       +2     
============================================
  Hits          33257    33257              
- Misses       219210   219220      +10     
+ Partials       4180     4179       -1

Impacted Files	Coverage Δ
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	`7.33% <0.00%> (-0.02%)`	⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shwstppr · 2022-09-30T04:49:16Z

@blueorangutan package

blueorangutan · 2022-09-30T04:50:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-09-30T05:36:12Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4323

DaanHoogland · 2022-09-30T09:55:41Z

@blueorangutan test

blueorangutan · 2022-09-30T09:56:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

shwstppr · 2022-09-30T10:16:52Z

@DaanHoogland please note I've not done any sort of testing for this yet

DaanHoogland · 2022-09-30T10:19:55Z

@DaanHoogland please note I've not done any sort of testing for this yet

I'll do some when I get around. Do you have any test advice on this? I couldn´t reproduce the issue on 4.17.

shwstppr · 2022-09-30T10:26:29Z

@DaanHoogland To reproduce, I think one needs to just select Automatically assign in the migrate instance form for a vm that has volumes on local storage,

For tests,

we will need to test this case which I feel would fail :-D
test for any regression - user vm migration, systemvm migration, vm storage migration using migrateVirtualMachineWithVolume API and maybe cross-cluster migration

blueorangutan · 2022-09-30T23:50:14Z

Trillian test result (tid-5059)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48674 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6785-t5059-kvm-centos7.zip
Smoke tests completed. 100 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_unsecure_vm_migration	`Error`	225.92	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	145.08	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	153.13	test_vm_life_cycle.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	605.48	test_kubernetes_clusters.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	650.62	test_vpc_redundant.py

weizhouapache

Nice enhancement

DaanHoogland · 2022-10-03T05:10:28Z

Nice enhancement

Did you test @weizhouapache ? I didn´t get to it yet.

weizhouapache · 2022-10-04T15:26:11Z

Nice enhancement

Did you test @weizhouapache ? I didn´t get to it yet.

I have not tested it yet

github-actions · 2022-10-28T13:35:19Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

...main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java

DaanHoogland · 2023-04-17T11:25:10Z

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java


-    private boolean isVmVolumesOnZoneWideStore(VMInstanceVO vm) {
-        final List<VolumeVO> volumes = _volsDao.findCreatedByInstance(vm.getId());
+    private boolean isVmVolumesUsingLocalStorage(final List<VolumeVO> volumes) {


The code in this method looks exactly like the bit in isVmVolumesOnZoneWideStore

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

DaanHoogland · 2023-04-17T11:27:09Z

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

+        if (destinationHost == null) {
+            Long poolId = null;
+            if (MapUtils.isNotEmpty(volToPoolObjectMap)) {
+                poolId = new ArrayList<>(volToPoolObjectMap.values()).get(0);
+            }
+            DeployDestination deployDestination = chooseVmMigrationDestination(vm, srcHost, poolId);
+            if (deployDestination == null) {
+                throw new CloudRuntimeException("Unable to find suitable destination to migrate VM " + vm.getInstanceName());
+            }
+            destinationHost = deployDestination.getHost();
+        }


can this be extracted?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2023-05-23T18:26:40Z

@blueorangutan package

blueorangutan · 2023-05-23T18:28:03Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-05-23T19:16:09Z

Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6130

blueorangutan · 2023-05-23T20:31:39Z

Packaging result [LL]: ✖️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6054

blueorangutan · 2023-05-24T07:20:13Z

Packaging result [LL]: ✖️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6055

blueorangutan · 2023-05-24T07:28:05Z

Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6136

shwstppr · 2023-05-24T07:52:29Z

@blueorangutan package

blueorangutan · 2023-05-24T07:54:03Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

shwstppr · 2023-05-29T10:39:11Z

Recreated here #7554

server, api, ui: allow host auto-select for migrateVirtualMachineWith…

f991e4e

…Volume Fixes apache#6773 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added component:api component:UI labels Sep 29, 2022

shwstppr changed the title ~~server, api, ui: allow host auto-select for migrateVirtualMachineWith…~~ api, server, ui: allow host auto-select for migrateVirtualMachineWith… Sep 29, 2022

fix

4b4404f

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

weizhouapache reviewed Oct 2, 2022

View reviewed changes

DaanHoogland added the status:needs-testing label Oct 11, 2022

github-actions bot added the status:has-conflicts label Oct 28, 2022

Merge branch 'main' into add-automigrate-localstorage

b14536a

github-actions bot removed the status:has-conflicts label Dec 28, 2022

Merge branch 'main' into add-automigrate-localstorage

f2205e5

yadvr requested a review from DaanHoogland April 13, 2023 09:45

yadvr added this to the 4.19.0.0 milestone Apr 13, 2023

DaanHoogland reviewed Apr 17, 2023

View reviewed changes

shwstppr added 3 commits May 23, 2023 17:49

fix

0f997aa

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Merge branch 'main' into add-automigrate-localstorage

c1328e8

changes

ca89f2a

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

apache deleted a comment from blueorangutan May 23, 2023

fix

919c4e6

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr closed this May 24, 2023

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

shwstppr commented Sep 29, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented Sep 29, 2022

Uh oh!

blueorangutan commented Sep 29, 2022

Uh oh!

acs-robot commented Sep 29, 2022

Uh oh!

blueorangutan commented Sep 29, 2022

Uh oh!

blueorangutan commented Sep 29, 2022

Uh oh!

blueorangutan commented Sep 29, 2022

Uh oh!

sonarqubecloud bot commented Sep 29, 2022

Uh oh!

codecov bot commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

DaanHoogland commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

shwstppr commented Sep 30, 2022

Uh oh!

DaanHoogland commented Sep 30, 2022

Uh oh!

shwstppr commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Oct 3, 2022

Uh oh!

weizhouapache commented Oct 4, 2022

Uh oh!

github-actions bot commented Oct 28, 2022

Uh oh!

Uh oh!

DaanHoogland Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DaanHoogland Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

shwstppr commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 23, 2023

Uh oh!

blueorangutan commented May 24, 2023

Uh oh!

blueorangutan commented May 24, 2023

Uh oh!

shwstppr commented May 24, 2023

Uh oh!

blueorangutan commented May 24, 2023

Uh oh!

shwstppr commented May 29, 2023

codecov bot commented Sep 29, 2022 •

edited

Loading