pre-commit: standardize more line endings to lf#7804
pre-commit: standardize more line endings to lf#7804DaanHoogland merged 1 commit intoapache:mainfrom
lf#7804Conversation
Codecov Report
@@ Coverage Diff @@
## main #7804 +/- ##
=============================================
+ Coverage 13.44% 28.45% +15.01%
- Complexity 9400 29631 +20231
=============================================
Files 2747 5102 +2355
Lines 258844 381661 +122817
Branches 40313 62409 +22096
=============================================
+ Hits 34804 108606 +73802
- Misses 219655 258242 +38587
- Partials 4385 14813 +10428
Flags with carried forward coverage won't be shown. Click here to find out more. see 3649 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@blueorangutan package |
|
@jbampton a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6632 |
DaanHoogland
left a comment
There was a problem hiding this comment.
lgtm, though a lot of the touched files seem unmaintained
We could also "exclude" files/folders from this check perhaps for this case of unmaintained files |
as long as it passes, never mind |
shwstppr
left a comment
There was a problem hiding this comment.
code changes look good. Lets run a round of smoke test as the number of files changed
@blueorangutan package
|
@blueorangutan package |
|
@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7396 |
|
@blueorangutan test |
|
@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-7994)
|
https://github.com/pre-commit/pre-commit-hooks#mixed-line-ending
Description
This PR extends the "mixed line endings" pre-commit hook to apply to more file types.
Just trying to create a code standard to follow.
You can test locally from the repo root with:
pre-commit run --all-filesTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?