Fix allignment on layout on right panel#8060
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8060 +/- ##
============================================
+ Coverage 4.78% 29.15% +24.37%
- Complexity 0 30845 +30845
============================================
Files 346 5150 +4804
Lines 26150 363420 +337270
Branches 4497 53230 +48733
============================================
+ Hits 1252 105972 +104720
- Misses 24763 242905 +218142
- Partials 135 14543 +14408
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4813 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
harikrishna-patnala
force-pushed
the
FixAllignment
branch
2 times, most recently
from
e40c0e1 to
44bf80f
Compare
|
@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
LGTM but I think the button makes it awkward - should button be similarly aligned by height? |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
looks good generally, one question
| :value="filterValue" | ||
| style="min-width: 120px; margin-left: 10px; margin-top: -4px" | ||
| style="min-width: 100px; margin-left: 10px; margin-top: -4px" | ||
| size=small |
There was a problem hiding this comment.
I've seen console errors on "large" and "small" in the past. Where are thos defined, and are we sure this is not an issue here?
There was a problem hiding this comment.
I dont see any errors now @DaanHoogland, probably due to ant3 upgrade.
That is the whole point, both Project/Metrics are shorter (not the same height) than the "Refresh" button and "Active" dropdown), while the main BLUE buttons (Add instance, Add network, Add VPC, etc) - are higher than the rest - which we might want to make same heigh as the white buttons? |
harikrishna-patnala
force-pushed
the
FixAllignment
branch
from
e1318c5 to
4d57c01
Compare
I've moved the "Filter" button next to refresh button to group the hallow components and grey radio buttons together. It looks like this
|
|
@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
andrijapanicsb
left a comment
andrijapanicsb
left a comment
There was a problem hiding this comment.
LGTM, after visual inspection
7 participants
Description
This is a followup for the PR #7434, here we are making some more improvements
from
to
Along the with search box allignment, fixed the font sizes and check box sizes
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity