ui: fix haenable in edit vm form

[shwstppr]

Description

Fixes #8510

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[DaanHoogland]

@shwstppr you mention 8150, is this a typo? It seems to be about something else.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9049 (QA-JID-334)

[shwstppr]

@shwstppr you mention 8150, is this a typo? It seems to be about something else.

Yes, @DaanHoogland. I've fixed now

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.01%. Comparing base (87e7c57) to head (8af513f).
Report is 117 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9049      +/-   ##
============================================
+ Coverage     14.96%   16.01%   +1.05%     
- Complexity    10995    11529     +534     
============================================
  Files          5373     5062     -311     
  Lines        469005   444507   -24498     
  Branches      58953    52521    -6432     
============================================
+ Hits          70198    71205    +1007     
+ Misses       391036   365392   -25644     
- Partials       7771     7910     +139     

Flag	Coverage Δ
uitests	?
unittests	16.01% <ø> (+0.34%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm

[DaanHoogland]

@shwstppr , i tried in QA but don't see the check for ha in the edit vm dialog there. Is this available in main only?

[shwstppr]

VM offering should offer HA.
Here is one such VM, https://qa.cloudstack.cloud/simulator/pr/9049/#/vm/ca609571-ab79-4d65-b572-49b2f701d109

[shwstppr]

@DaanHoogland ^^

[DaanHoogland]

thanks, @shwstppr clear (and of course 🤦 )
LGTM

[weizhouapache]

qa looks good

[weizhouapache]

@shwstppr I have changed the target to 4.19

@blueorangutan ui

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[weizhouapache]

verified OK on QA: https://qa.cloudstack.cloud/simulator/pr/9049/#/vm/28927242-410b-4e4e-a5bf-e33740b8e240

please note, the service offering must offer HA. otherwise, user will see the following error when update vm to ha-enabled

(localcloud) 🐱 > update virtualmachine id=2446f9d9-83ad-4b4c-bf3e-df041a390fcf haenable=true
🙈 Error: (HTTP 530, error code 4250) Failed to update VM, due to: Can't enable ha for the vm as it's created from the Service offering having HA disabled

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9049 (QA-JID-335)