Skip to content

Experiments#819

Draft
garydgregory wants to merge 313 commits intofix/read-onlyfrom
master
Draft

Experiments#819
garydgregory wants to merge 313 commits intofix/read-onlyfrom
master

Conversation

@garydgregory
Copy link
Copy Markdown
Member

@garydgregory garydgregory commented Dec 14, 2025

No description provided.

garydgregory and others added 30 commits November 8, 2025 11:21
@garydgregory
No need to override project/issueManagement/system
f07af41
@dependabot
Bump commons-codec:commons-codec from 1.19.0 to 1.20.0 (#812)
3c659ec 
Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.19.0 to 1.20.0.
- [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt)
- [Commits](apache/commons-codec@rel/commons-codec-1.19.0...rel/commons-codec-1.20.0)

---
updated-dependencies:
- dependency-name: commons-codec:commons-codec
  dependency-version: 1.20.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@garydgregory
Bump commons-codec:commons-codec from 1.19.0 to 1.20.0 #812
524ab6d
@dependabot
Bump github/codeql-action from 4.31.2 to 4.31.3 (#815)
baf2c57 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.2 to 4.31.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@0499de3...014f16e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/dependency-review-action from 4.8.1 to 4.8.2 (#813)
60f411c 
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.8.1 to 4.8.2.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](actions/dependency-review-action@40c09b7...3c4e3dc)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-version: 4.8.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump org.apache.commons:commons-parent from 91 to 92 (#816)
6c44e82 
Bumps [org.apache.commons:commons-parent](https://github.com/apache/commons-parent) from 91 to 92.
- [Changelog](https://github.com/apache/commons-parent/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-parent/commits)

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-parent
  dependency-version: '92'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@garydgregory
Bump org.apache.commons:commons-parent from 91 to 92 #816
6a003a6
@dependabot
Bump commons.bytebuddy.version from 1.17.8 to 1.18.1 (#814)
adf79ee 
Bumps `commons.bytebuddy.version` from 1.17.8 to 1.18.1.

Updates `net.bytebuddy:byte-buddy` from 1.17.8 to 1.18.1
- [Release notes](https://github.com/raphw/byte-buddy/releases)
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md)
- [Commits](raphw/byte-buddy@byte-buddy-1.17.8...byte-buddy-1.18.1)

Updates `net.bytebuddy:byte-buddy-agent` from 1.17.8 to 1.18.1
- [Release notes](https://github.com/raphw/byte-buddy/releases)
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md)
- [Commits](raphw/byte-buddy@byte-buddy-1.17.8...byte-buddy-1.18.1)

---
updated-dependencies:
- dependency-name: net.bytebuddy:byte-buddy
  dependency-version: 1.18.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: net.bytebuddy:byte-buddy-agent
  dependency-version: 1.18.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@garydgregory
Bump commons.bytebuddy.version from 1.17.8 to 1.18.1 #814
2227467
@sebbASF
Dependabot => quarterly
0e5b109
@garydgregory
Bump commons-lang3 from 3.19.0 to 3.20.0
7aeb468
@garydgregory
Use HTTPS to download XML Schema
2758094
@garydgregory
Bump CodeQL 4.31.4
ffc7299
@garydgregory
Bump actions/checkout from v5.0.0 to v6.0.0
a47e410
@garydgregory
Bump org.apache.commons:commons-parent from 92 to 93
e9aeb4c 
- Inherit scm element
- Inherit ciManagement element
- Inherit issueManagement element
@garydgregory
Fix Apache RAT plugin console warnings
dcdbdf3
@garydgregory
Javadoc
7001cee
@garydgregory
Bump github/codeql-action from 4.31.4 to 4.31.5
903b4d4
@garydgregory
Bump github/codeql-action from 4.31.4 to 4.31.5
6678f81
@garydgregory
Bump github/codeql-action from 4.31.5 to 4.31.6
4e6c051
@garydgregory
Bump github/codeql-action from 4.31.5 to 4.31.6
313950c
@garydgregory
Bump commons.bytebuddy.version from 1.18.1 to 1.18.2
62d7cbe
@garydgregory
Bump actions/checkout from 6.0.0 to 6.0.1
0309fe3
@garydgregory
Bump actions/setup-java from 5.0.0 to 5.1.0
05e4956
@garydgregory
Fix benchmarks
a665202
@garydgregory
Javadoc
d2e39b6
@garydgregory
Bump github/codeql-action from 4.31.6 to 4.31.7
013aae2
@garydgregory
Ask for details on AI usage in creating a pull request
d0af7d5
@garydgregory
Add NetBean IDE metadata files to .gitignore
3557766
@garydgregory
ByteArraySeekableByteChannel.position|truncate(long) shouldn't throw …
208887b 
…an IllegalArgumentException for a new positive position that's too large (#817)

* [IO-856] Try test on all OSs for GitHub CI

* ByteArraySeekableByteChannel.position|truncate(long) shouldn't throw an
IllegalArgumentException for a new positive position that's too large

* Throw IOException instead of OutOfMemoryError

* Refactor internals for safer and less type casting
garydgregory and others added 20 commits April 7, 2026 08:24
@garydgregory
Feature/channel filters (#837)
3d1b9dc 
* [IO-856] Try test on all OSs for GitHub CI

* Add channel filters

* Rename test class

* Javadoc

* Add FilterFileChannel
@garydgregory
Add filter channels.
853b91c
@garydgregory
Bump org.apache.commons:commons-parent from 97 to 98
530e346
@garydgregory
[IO- 889] Add test for Tailer close() (#842)
2ab33b4 
* [IO-856] Try test on all OSs for GitHub CI

* [IO-889] Tailer.close() does not guarantee file close

- Add test class
- Green on macOS locally

* [IO-889] Tailer.close() does not guarantee file close

- Add test class
- Green on macOS locally
- Fails on Windows on GH CI
@garydgregory
Add CloseShieldChannelFilterByteChannelTest
93de0e4
@garydgregory
Fix Javadoc typo
ec308ac
@garydgregory
Javadoc
f96d650
@garydgregory
Update Javadoc and constructors in the channels package (#843)
01de46e 
* [IO-856] Try test on all OSs for GitHub CI

* Javadoc

- Make some package-private constructors private
- Provide "default" constructors for simple use cases
@garydgregory
Bump actions/cache from 5.0.4 to 5.0.5
db99d02
@garydgregory
Bump actions/upload-artifact from 7.0.0 to 7.0.1
738d8ed
@garydgregory
Fix JaCoCo report generation
61e347b
@garydgregory
Add missing test for
6857f38 
UnsynchronizedBufferedReader.UnsynchronizedBufferedReader(Reader, int)
@garydgregory
Add missing test for UnsynchronizedBufferedReader.mark(int)
443f21d
@garydgregory
Add missing test for UnsynchronizedBufferedReader.skip(int)
354e37c
@garydgregory
AbstractStreamBuilder.setBufferSizeDefault(int) now resets to default
a7cc1ba 
for input less than or equal to zero.

Javadoc
@garydgregory
Better action description.
5ee4bc4
@garydgregory
Bump github/codeql-action from 4.35.1 to 4.35.2
d4d2573
@garydgregory
Sort members
7cc1ede
@garydgregory
Use final
d9184ed
@garydgregory
Prepare for the next release candidate
43b9994
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 19, 2026
View reviewed changes
Comment thread src/main/java/org/apache/commons/io/input/BoundedReader.java

@Override
public long skip(final long n) throws IOException {
charsRead += n;

Check failure

Code scanning / CodeQL

Implicit narrowing conversion in compound assignment High

Implicit cast of source type long to narrower destination type
int
Loading
.

Copilot Autofix

AI 9 days ago

To fix this without changing intended behavior, avoid compound assignment between int and long. Compute the actual skipped amount from the underlying reader first, then update charsRead using a checked conversion from long to int.

Best fix in this file:

  • In skip(long n), replace:
    • charsRead += n;
    • return super.skip(n);
  • With:
    • final long skipped = super.skip(n);
    • charsRead = Math.addExact(charsRead, Math.toIntExact(skipped));
    • return skipped;

Why this is best:

  • Removes implicit narrowing conversion.
  • Tracks real skipped count (more accurate than adding requested n).
  • Fails fast with clear arithmetic exception on impossible overflow/truncation instead of silent corruption.
  • Requires no new imports (Math is in java.lang).
Suggested changeset 1
src/main/java/org/apache/commons/io/input/BoundedReader.java

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/main/java/org/apache/commons/io/input/BoundedReader.java b/src/main/java/org/apache/commons/io/input/BoundedReader.java
--- a/src/main/java/org/apache/commons/io/input/BoundedReader.java
+++ b/src/main/java/org/apache/commons/io/input/BoundedReader.java
@@ -132,7 +132,8 @@
 
     @Override
     public long skip(final long n) throws IOException {
-        charsRead += n;
-        return super.skip(n);
+        final long skipped = super.skip(n);
+        charsRead = Math.addExact(charsRead, Math.toIntExact(skipped));
+        return skipped;
     }
 }
EOF
@@ -132,7 +132,8 @@

@Override
public long skip(final long n) throws IOException {
charsRead += n;
return super.skip(n);
final long skipped = super.skip(n);
charsRead = Math.addExact(charsRead, Math.toIntExact(skipped));
return skipped;
}
}
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@garydgregory @github-advanced-security @sebbASF @KishorMore-2005 @peterdemaeyer @mawiesne