fix(android): Notifications now stop and clears the channel#114
Open
m1aw wants to merge 1 commit intoapache:masterfrom
Open
fix(android): Notifications now stop and clears the channel#114m1aw wants to merge 1 commit intoapache:masterfrom
m1aw wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
no possible side effects? |
Author
|
As far as we could test, no there are no side effects, so we decided to use it in production. |
Member
|
CI, please rerun tests. |
Member
|
Android tests are not happy: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
Ensures notifications stop after playing.
This fixes the issue we had when after 15 notifications, the 16th notification would not play the sound.
What testing has been done on this change?
Use previous version, spam .beep() 16, the 16th notification will not play.
Use this version, the issue is fixed.
Checklist