Skip to content

Fix view server crash when map/reduce function throws null #5944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vamsi2246 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

Fix view server crash when map/reduce function throws null #5944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
477db91
Fix view server crash when map/reduce function throws null
Mar 26, 2026
c7c62b6
Merge branch 'main' into fix-null-crash-view-server
vamsi2246 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions share/server/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ var Couch = {
};

function errstr(e) {
if (e == null) return String(e);
// toSource() is a Spidermonkey "special"
return (e.toSource ? e.toSource() : e.toString());
};
Expand Down
4 changes: 2 additions & 2 deletions share/server/views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ var Views = (function() {
// JavaScript process. If you need to destroy the JavaScript
// process, throw the error form matched by the block below.
throw(["error", "map_runtime_error", "function raised 'fatal_error'"]);
} else if (err[0] == "fatal") {
} else if (err && err[0] == "fatal") {
// Throwing errors of the form ["fatal","error_key","reason"]
// will kill the OS process. This is not normally what you want.
throw(err);
} else if (err.name == "InternalError") {
} else if (err && err.name == "InternalError") {
throw(["fatal", err.name, err.message]);
}
var message = "function raised exception " + errstr(err);
Expand Down