CXF-9116: Remove org.apache.cxf.feature.LoggingFeature#2807
Conversation
d1fe633 to
a76b407
Compare
|
|
||
| SecurityContext httpSecurityContext = new SecurityContext() { | ||
| final HttpServletRequest reqFromInMessage = (HttpServletRequest)exchange.getInMessage().get(HTTP_REQUEST); | ||
| final SecurityContext httpSecurityContext = new SecurityContext() { |
There was a problem hiding this comment.
@ffang some refactoring here: a number of cxf-*-security tests were failing due to logging change: apparently when DefaultLogEventMapper is called, the underlying HTTP request is already recycled and fails with NPE (jetty/jetty.project#12080). To mitigate that, at least for getUserPrincipal() - capturing principal early.
There was a problem hiding this comment.
@reta I think, that this change lead to some issues in TomEE. Some details are here: https://lists.apache.org/thread/bfxq109lwqzht7x8hlrjgltogh79t9sh (due to caching the principal early instead of evaluating it on demand (after some processing has happened). For us in TomEE, it leads to some downstream issues in the MicroProfile JWT TCK.
There was a problem hiding this comment.
Thank you @rzo1 , I suspected some issues here (but still hoped we won't hit them), I will be looking into other options shortly.
There was a problem hiding this comment.
#2890 - would love to hear the feedback, thank you
Remove org.apache.cxf.feature.LoggingFeature. It has been deprecated for a long time and should be removed, the replacement exists.
<logging>namespace handler in cxf-core (since logging feature is not part of core anymore): replacement is<bean class="org.apache.cxf.ext.logging.LoggingFeature"/>along with