feat: Add SQL expression support for with_columns#1286
Merged
timsaucer merged 7 commits intoapache:mainfrom Oct 28, 2025
Merged
feat: Add SQL expression support for with_columns#1286timsaucer merged 7 commits intoapache:mainfrom
with_columns#1286timsaucer merged 7 commits intoapache:mainfrom
Conversation
6 tasks
Contributor
hendrikmakait
left a comment
hendrikmakait
left a comment
There was a problem hiding this comment.
This looks like a nice UX improvement! I have a couple of comments/suggestions, feel free to ignore me.
Co-authored-by: Hendrik Makait <hendrik@makait.com>
Co-authored-by: Hendrik Makait <hendrik@makait.com>
Contributor
Author
|
Thanks for review @hendrikmakait |
timsaucer
approved these changes
Oct 24, 2025
Member
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
One small recommendation. I think this is great work!
| :func:`datafusion.col` or :func:`datafusion.lit`, or SQL expression strings. | ||
| To pass named expressions use the form ``name=Expr``. | ||
|
|
||
| Example usage: The following will add 4 columns labeled ``a``, ``b``, ``c``, |
Member
There was a problem hiding this comment.
It would be really nice to add a simple example of a SQL expression right here.
Member
|
Thank you @milenkovicm and @hendrikmakait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
in relation to #1278 but does not close it
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
backward compatible change