Support async iteration of RecordBatchStream#975
Merged
timsaucer merged 5 commits intoapache:mainfrom Jan 9, 2025
Merged
Conversation
Member
Author
|
If this looks good, we can add a test using pytest-asyncio |
Member
|
At first glance, this looks like a very nice add. Do you need help resolving the test failures? |
Member
Author
Member
Author
|
I'd like to add a test with pytest-asyncio, but I don't know how to add the dependency, ref #977 |
timsaucer
reviewed
Jan 7, 2025
Member
timsaucer
left a comment
There was a problem hiding this comment.
Now that I've had a chance to actually review, this looks great. Can we add an issue to track the unit test for pytest-asyncio after the update to uv for package management?
timsaucer
reviewed
Jan 8, 2025
…ate the type hint.
Member
Author
|
Thanks for making that update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Which issue does this PR close?
Closes #974 .
Rationale for this change
Support async iteration of RecordBatchStream.
What changes are included in this PR?
StopIterationorAsyncStopIterationerrorsSendableRecordBatchStreaminto anArc<Mutex<>>. This is required I think so that we can clone the stream intofuture_into_pyAre there any user-facing changes?
Adds async iterator support.