[vibebench] Optimize primitive group-by intern with batch hashing and local dedup#21042
Closed
Dandandan wants to merge 1 commit intoapache:mainfrom
Closed
[vibebench] Optimize primitive group-by intern with batch hashing and local dedup#21042Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan wants to merge 1 commit intoapache:mainfrom
Conversation
…sing, and local dedup - Use `with_hashes` for batch hash computation via thread-local buffer, separating hashing from hash table ops for better vectorization - Process 4 rows at a time via `chunks_exact(4)` with local dedup to reduce redundant hash table operations - Split lookup into find + insert_unique phases (lighter than `entry`) - Extract find_group, insert_new_group, get_or_create_null_group helpers to consolidate duplicated unsafe hash table logic with SAFETY comments - Separate null/no-null fast paths to eliminate validity checks when no nulls are present Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dandandan
changed the title
Contributor
Author
|
run benchmarks |
|
🤖 Benchmark completed (GKE) | trigger Details
Resource Usagetpch — base (merge-base)
tpch — branch
|
|
🤖 Benchmark completed (GKE) | trigger Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
|
|
🤖 Benchmark completed (GKE) | trigger Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
|
Contributor
Author
|
run benchmark clickbench_extended |
|
🤖 Benchmark completed (GKE) | trigger Details
Resource Usageclickbench_extended — base (merge-base)
clickbench_extended — branch
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with_hashesfor batch hash computation via thread-local buffer, separating hashing from hash table ops for better vectorization/pipeliningchunks_exact(4)with local dedup within each chunk to reduce redundant hash table operationsfind+insert_uniquephases (lighter thanentrywhich prepares an insertion slot even on hit)find_group,insert_new_group,get_or_create_null_grouphelpers to consolidate unsafe hash table logic with SAFETY commentsTest plan
cargo test -p datafusion-physical-plan aggregat(82 tests pass)cargo clippy -p datafusion-physical-plan --all-features -- -D warnings(clean)cargo fmt --all(clean)🤖 Generated with Claude Code