-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: arrays_zip/list_zip allow single array argument
#21047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hsiang-c
wants to merge
3
commits into
apache:main
Choose a base branch
from
hsiang-c:single_arg_arrays_zip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−14
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7324,6 +7324,50 @@ select arrays_zip(a, b) from (values ([1, 2], [10, 20]), (null, [30, 40]), ([5, | |
| [{1: NULL, 2: 30}, {1: NULL, 2: 40}] | ||
| [{1: 5, 2: NULL}, {1: 6, 2: NULL}] | ||
|
|
||
| # column-level test with single argument | ||
| query ? | ||
| select arrays_zip(a) from (values ([1, 2], [10, 20]), (null, [30, 40]), ([5, 6], null)) as t(a, b); | ||
| ---- | ||
| [{1: 1}, {1: 2}] | ||
| NULL | ||
| [{1: 5}, {1: 6}] | ||
|
|
||
| query ? | ||
| select arrays_zip(b) from (values ([1, 2], [10, 20]), (null, [30, 40]), ([5, 6], null)) as t(a, b); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test on column |
||
| ---- | ||
| [{1: 10}, {1: 20}] | ||
| [{1: 30}, {1: 40}] | ||
| NULL | ||
|
|
||
| # null input | ||
| query ? | ||
| select arrays_zip(null) | ||
| ---- | ||
| NULL | ||
|
|
||
| # single empty array | ||
| query ? | ||
| select arrays_zip([]) | ||
| ---- | ||
| [] | ||
|
|
||
|
|
||
| # single array of null | ||
| query ? | ||
| select arrays_zip([null]) | ||
| ---- | ||
| [{1: NULL}] | ||
|
|
||
| query ? | ||
| select arrays_zip([NULL::int]) | ||
| ---- | ||
| [{1: NULL}] | ||
|
|
||
| query ? | ||
| select arrays_zip([NULL::int[]]) | ||
| ---- | ||
| [{1: NULL}] | ||
|
|
||
| # alias: list_zip | ||
| query ? | ||
| select list_zip([1, 2], [3, 4]); | ||
|
|
@@ -7346,9 +7390,11 @@ select arrays_zip([42], ['hello']); | |
| ---- | ||
| [{1: 42, 2: hello}] | ||
|
|
||
| # error: too few arguments | ||
| statement error | ||
| # single argument | ||
| query ? | ||
| select arrays_zip([1, 2, 3]); | ||
| ---- | ||
| [{1: 1}, {1: 2}, {1: 3}] | ||
|
|
||
| # arrays_zip with LargeList inputs | ||
| query ? | ||
|
|
@@ -7368,6 +7414,12 @@ select arrays_zip( | |
| ---- | ||
| [{1: 1, 2: 10}, {1: 2, 2: 20}, {1: NULL, 2: 30}] | ||
|
|
||
| # single argument from LargeList | ||
| query ? | ||
| select arrays_zip(arrow_cast(make_array(1, 2, 3), 'LargeList(Int64)')); | ||
| ---- | ||
| [{1: 1}, {1: 2}, {1: 3}] | ||
|
|
||
| # arrays_zip with FixedSizeList inputs | ||
| query ? | ||
| select arrays_zip( | ||
|
|
@@ -7377,6 +7429,12 @@ select arrays_zip( | |
| ---- | ||
| [{1: 1, 2: 10}, {1: 2, 2: 20}, {1: 3, 2: 30}] | ||
|
|
||
| # single argument from FixedSizeList | ||
| query ? | ||
| select arrays_zip(arrow_cast(make_array(1, 2, 3), 'FixedSizeList(3, Int64)')); | ||
| ---- | ||
| [{1: 1}, {1: 2}, {1: 3}] | ||
|
|
||
| # arrays_zip mixing List and LargeList | ||
| query ? | ||
| select arrays_zip( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test on column
a