Skip to content

[Chore] Remove LICENSE files of dependencies under Apache License 2.0#17768

Open
ruanwenjun wants to merge 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_removeUnusedLicense
Open

[Chore] Remove LICENSE files of dependencies under Apache License 2.0#17768
ruanwenjun wants to merge 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_removeUnusedLicense

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

According to https://www.apache.org/legal/release-policy.html#license-file, we don't need to import this.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

@ruanwenjun ruanwenjun marked this pull request as draft December 8, 2025 01:39
@ruanwenjun ruanwenjun changed the title [Chore] Remove LICENSE files of dependencies under Apache License 2.0 [WIP][Chore] Remove LICENSE files of dependencies under Apache License 2.0 Dec 8, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedLicense branch from 945afbd to 83c1356 Compare March 18, 2026 14:35
@ruanwenjun ruanwenjun requested review from Copilot March 18, 2026 14:35
@ruanwenjun ruanwenjun marked this pull request as ready for review March 18, 2026 14:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes bundled third-party LICENSE text files from the distribution release docs, based on the claim that Apache License 2.0 dependency LICENSE files do not need to be imported into the project’s LICENSE materials.

Changes:

  • Delete multiple dependency-specific license files under dolphinscheduler-dist/release-docs/licenses/
  • Delete UI dependency license files under dolphinscheduler-dist/release-docs/licenses/ui-licenses/
  • Reduce duplication of embedded Apache License 2.0 text in the release-docs license directory

Reviewed changes

Copilot reviewed 87 out of 263 changed files in this pull request and generated no comments.

Show a summary per file
File Description
dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-typescript Removes embedded Apache-2.0 license text for the UI dependency entry.
dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-roboto Removes Roboto license note from UI licenses.
dolphinscheduler-dist/release-docs/licenses/ui-licenses/LICENSE-open-sans Removes Open Sans license note from UI licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-zookeeper.txt Removes embedded Apache-2.0 license text for Zookeeper entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-utils.txt Removes embedded Apache-2.0 license text for utils entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-token-provider.txt Removes embedded Apache-2.0 license text for token-provider entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-swagger-ui.txt Removes embedded apache licensing notice for swagger-ui entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-swagger-models.txt Removes embedded apache licensing notice for swagger-models entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-swagger-bootstrap-ui.txt Removes embedded Apache-2.0 license text for swagger-bootstrap-ui entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-swagger-annotations.txt Removes embedded apache licensing notice for swagger-annotations entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-snowflake.txt Removes embedded apache licensing notice for snowflake entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-snappy.txt Removes embedded Apache-2.0 license text for snappy entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-snappy-java.txt Removes embedded Apache-2.0 license text for snappy-java entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-snakeyaml.txt Removes embedded Apache-2.0 license text for snakeyaml entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-sdk-core.txt Removes embedded Apache-2.0 license text for sdk-core entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-regions.txt Removes embedded Apache-2.0 license text for regions entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-quartz.txt Removes embedded Apache-2.0 license text for quartz entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-profiles.txt Removes embedded Apache-2.0 license text for profiles entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-netty.txt Removes embedded Apache-2.0 license text for netty entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-netty-all.txt Removes embedded Apache-2.0 license text for netty-all entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-leveldbjni-all.txt Removes embedded license text for leveldbjni-all entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-lang-tag.txt Removes embedded Apache-2.0 license text for lang-tag entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jsr305.txt Removes embedded Apache-2.0 license text for jsr305 entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jsqlparser.txt Removes embedded Apache-2.0 license text for jsqlparser entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-json-utils.txt Removes embedded Apache-2.0 license text for json-utils entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-json-smart.txt Removes embedded Apache-2.0 license text for json-smart entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jna.txt Removes JNA licensing note (dual license) from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jna-platform.txt Removes JNA-platform licensing note (dual license) from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jackson-mapper-asl.txt Removes Jackson mapper ASL license note from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jackson-datatype-jsr310.txt Removes Jackson datatype jsr310 license note from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jackson-databind.txt Removes Jackson databind license note from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jackson-core.txt Removes Jackson core license note from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jackson-core-asl.txt Removes Jackson core ASL license note from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-jackson-annotations.txt Removes Jackson annotations license note from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-ion-java.txt Removes embedded Apache-2.0 license text for ion-java entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-httpclient.txt Removes embedded Apache-2.0 license text for httpclient entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-guice.txt Removes embedded Apache-2.0 license text for guice entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-grpc.txt Removes embedded Apache-2.0 license text for grpc entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-failsafe.txt Removes embedded Apache-2.0 license text for failsafe entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-eventstream.txt Removes embedded Apache-2.0 license text for eventstream entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-druid.txt Removes embedded Apache-2.0 license text for druid entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-content-type.txt Removes embedded Apache-2.0 license text for content-type entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-client-java.txt Removes embedded Apache-2.0 license text for client-java entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-classmate.txt Removes ClassMate license note from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-checker-compat-qual.txt Removes embedded MIT license text for checker-compat-qual entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-aws-sdk-java.txt Removes embedded Apache-2.0 license text (plus JSON license note) for aws-sdk-java entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-avro.txt Removes embedded Apache-2.0 license text for avro entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-automaton.txt Removes embedded BSD-style license text for automaton entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-auto-value.txt Removes embedded Apache-2.0 license text for auto-value entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-auto-service-annotations.txt Removes auto-service-annotations Apache-2.0 notice from release-docs licenses.
dolphinscheduler-dist/release-docs/licenses/LICENSE-auth.txt Removes embedded Apache-2.0 license text for auth entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-annotations.txt Removes embedded Apache-2.0 license text for annotations entry.
dolphinscheduler-dist/release-docs/licenses/LICENSE-HikariCP.txt Removes embedded Apache-2.0 license text for HikariCP entry.
Comments suppressed due to low confidence (1)

dolphinscheduler-dist/release-docs/licenses/LICENSE-checker-compat-qual.txt:1

  • The PR title/description states this removes LICENSE files of dependencies under Apache License 2.0, but this file is clearly MIT-licensed. Please either (a) exclude non-Apache-2.0 dependency license files from this cleanup, or (b) update the PR title/description (and rationale) to match the broader removal scope.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sonarqubecloud
Copy link

@ruanwenjun ruanwenjun requested a review from Copilot March 19, 2026 13:42
@ruanwenjun ruanwenjun changed the title [WIP][Chore] Remove LICENSE files of dependencies under Apache License 2.0 [Chore] Remove LICENSE files of dependencies under Apache License 2.0 Mar 19, 2026
@ruanwenjun ruanwenjun added this to the 3.4.2 milestone Mar 19, 2026
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Mar 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 87 out of 263 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

dolphinscheduler-dist/release-docs/licenses/LICENSE-automaton.txt:1

  • This file contains a BSD-style license (not Apache License 2.0). Please confirm the associated dependency is no longer included in the release artifacts; otherwise its license text/attribution still needs to be retained somewhere in release-docs.
    dolphinscheduler-dist/release-docs/licenses/LICENSE-aws-sdk-java.txt:1
  • This file includes additional non-Apache-2.0 terms (it mentions JSON.org's JSON License with the "Good, not Evil" clause). Removing it may drop required third-party license text/attribution; please confirm JSON-licensed code is not shipped anymore, or keep/include the JSON License text elsewhere per ASF release policy.
    dolphinscheduler-dist/release-docs/licenses/LICENSE-checker-compat-qual.txt:1
  • This file contains the MIT License text (not Apache License 2.0). Since the PR purpose is to remove only Apache-2.0 dependency LICENSE files, please clarify why this non-Apache license text is being removed (e.g., dependency no longer shipped) or keep it to avoid losing required attribution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants