[Opt](operator) Eliminate redundant copy in MultiCastOperator and fix wrong assume_mutable by zclllyybb · Pull Request #60386 · apache/doris

zclllyybb · 2026-01-30T03:56:23Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

we have COW and shallow_mutate, so for most of scenarios we dont need to explicitly copy block's data. this PR fixed this for MultiCastOperator. and fixed all founded misuses. added tests.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2026-01-30T03:56:28Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zclllyybb · 2026-01-30T03:56:58Z

run buildall

doris-robot · 2026-01-30T04:45:42Z

TPC-H: Total hot run time: 31834 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5193e292eaf17c49e7b6457e53646edcd7fe8e2a, data reload: false

------ Round 1 ----------------------------------
q1	17616	5297	5074	5074
q2	2020	306	184	184
q3	10258	1354	764	764
q4	10192	834	318	318
q5	7473	2140	1880	1880
q6	193	179	153	153
q7	873	747	601	601
q8	9257	1372	1087	1087
q9	5255	4800	4820	4800
q10	6814	1948	1568	1568
q11	488	291	281	281
q12	333	375	229	229
q13	17771	3999	3222	3222
q14	238	235	222	222
q15	895	830	809	809
q16	683	692	635	635
q17	635	813	459	459
q18	6835	6576	6481	6481
q19	1227	979	597	597
q20	379	330	224	224
q21	2585	2039	1971	1971
q22	354	303	275	275
Total cold run time: 102374 ms
Total hot run time: 31834 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5363	5318	5291	5291
q2	257	341	255	255
q3	2148	2687	2229	2229
q4	1367	1748	1331	1331
q5	4304	4209	4180	4180
q6	220	179	140	140
q7	2088	2107	1946	1946
q8	2550	2418	2408	2408
q9	7603	7562	7524	7524
q10	2851	3081	2600	2600
q11	546	516	454	454
q12	680	721	624	624
q13	3817	4448	3547	3547
q14	308	313	296	296
q15	871	816	822	816
q16	682	775	724	724
q17	1141	1428	1388	1388
q18	8216	7878	7680	7680
q19	859	825	819	819
q20	2125	2090	1955	1955
q21	4531	4314	4142	4142
q22	583	537	495	495
Total cold run time: 53110 ms
Total hot run time: 50844 ms

doris-robot · 2026-01-30T04:57:19Z

TPC-DS: Total hot run time: 190155 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5193e292eaf17c49e7b6457e53646edcd7fe8e2a, data reload: false

query5	4391	613	505	505
query6	321	229	220	220
query7	4220	461	254	254
query8	340	256	238	238
query9	8713	2765	2745	2745
query10	449	346	289	289
query11	16384	16456	16110	16110
query12	176	119	119	119
query13	1275	442	355	355
query14	6269	3184	2913	2913
query14_1	2859	2740	2695	2695
query15	194	184	169	169
query16	1000	457	446	446
query17	1059	661	562	562
query18	2434	422	313	313
query19	186	172	145	145
query20	123	119	119	119
query21	207	136	117	117
query22	4940	5142	4729	4729
query23	19074	18725	18273	18273
query23_1	18426	18487	18479	18479
query24	7156	1591	1193	1193
query24_1	1168	1187	1209	1187
query25	510	432	404	404
query26	1233	259	148	148
query27	2773	458	267	267
query28	4540	1880	1877	1877
query29	781	532	453	453
query30	318	249	221	221
query31	877	737	667	667
query32	84	79	79	79
query33	540	378	270	270
query34	877	887	547	547
query35	628	676	597	597
query36	1193	1197	1063	1063
query37	128	98	87	87
query38	2946	2882	2855	2855
query39	931	899	911	899
query39_1	886	875	890	875
query40	215	127	112	112
query41	64	59	61	59
query42	90	91	86	86
query43	424	405	403	403
query44	1277	709	706	706
query45	191	187	179	179
query46	833	953	565	565
query47	2074	2143	2073	2073
query48	307	315	225	225
query49	601	435	336	336
query50	703	262	203	203
query51	4090	4068	4110	4068
query52	90	87	77	77
query53	199	216	171	171
query54	280	247	241	241
query55	80	75	71	71
query56	285	279	289	279
query57	1376	1355	1287	1287
query58	263	259	253	253
query59	2123	2201	2094	2094
query60	322	325	307	307
query61	140	142	141	141
query62	593	555	514	514
query63	199	164	173	164
query64	4871	1142	906	906
query65	4346	4266	4368	4266
query66	1468	455	350	350
query67	17504	17598	17447	17447
query68	2377	1000	651	651
query69	403	313	289	289
query70	1035	914	904	904
query71	307	298	271	271
query72	5443	2608	3303	2608
query73	595	725	283	283
query74	9712	9627	9511	9511
query75	2433	2461	2030	2030
query76	2264	1044	640	640
query77	340	384	293	293
query78	11282	11499	10845	10845
query79	2336	880	558	558
query80	1701	491	453	453
query81	555	280	257	257
query82	986	151	116	116
query83	315	254	242	242
query84	255	121	99	99
query85	857	476	402	402
query86	442	306	295	295
query87	3147	3085	2990	2990
query88	3414	2556	2537	2537
query89	387	332	300	300
query90	1853	173	165	165
query91	163	157	125	125
query92	74	74	64	64
query93	1155	951	570	570
query94	675	274	288	274
query95	594	328	376	328
query96	628	507	224	224
query97	2490	2494	2442	2442
query98	223	221	222	221
query99	982	959	835	835
Total cold run time: 266016 ms
Total hot run time: 190155 ms

doris-robot · 2026-01-30T05:02:16Z

ClickBench: Total hot run time: 28.23 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5193e292eaf17c49e7b6457e53646edcd7fe8e2a, data reload: false

query1	0.05	0.04	0.04
query2	0.10	0.05	0.04
query3	0.25	0.08	0.08
query4	1.60	0.12	0.11
query5	0.27	0.24	0.24
query6	1.19	0.67	0.67
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.56	0.50	0.49
query10	0.55	0.54	0.52
query11	0.14	0.09	0.09
query12	0.13	0.10	0.10
query13	0.62	0.61	0.62
query14	1.06	1.05	1.06
query15	0.87	0.85	0.87
query16	0.39	0.38	0.39
query17	1.15	1.12	1.12
query18	0.22	0.21	0.20
query19	2.02	1.94	2.00
query20	0.02	0.01	0.01
query21	15.42	0.28	0.16
query22	4.93	0.06	0.05
query23	15.89	0.29	0.10
query24	2.42	0.51	0.33
query25	0.11	0.06	0.09
query26	0.15	0.13	0.14
query27	0.08	0.08	0.04
query28	4.64	1.14	0.96
query29	12.56	3.91	3.14
query30	0.28	0.14	0.11
query31	2.80	0.62	0.41
query32	3.24	0.59	0.49
query33	3.34	3.27	3.18
query34	16.26	5.46	4.76
query35	4.87	4.81	4.82
query36	0.65	0.49	0.49
query37	0.11	0.07	0.07
query38	0.08	0.04	0.04
query39	0.05	0.04	0.04
query40	0.18	0.16	0.16
query41	0.10	0.04	0.03
query42	0.04	0.03	0.02
query43	0.06	0.04	0.04
Total cold run time: 99.53 s
Total hot run time: 28.23 s

doris-robot · 2026-01-30T06:11:52Z

BE UT Coverage Report

Increment line coverage 73.68% (14/19) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.49% (19272/36716)
Line Coverage	35.97% (179072/497791)
Region Coverage	32.39% (138910/428836)
Branch Coverage	33.33% (60092/180275)

hello-stephen · 2026-01-30T08:49:10Z

BE Regression && UT Coverage Report

Increment line coverage 94.74% (18/19) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.58% (25761/35991)
Line Coverage	54.21% (269237/496614)
Region Coverage	51.81% (224472/433246)
Branch Coverage	53.23% (96342/181007)

zclllyybb · 2026-01-30T16:33:41Z

run buildall

Copilot

Pull request overview

This PR removes a redundant deep-copy in the MultiCast data path by relying on COW semantics, and updates several vectorized block/expr mutation sites to avoid in-place mutation when columns are shared. It also adds a regression suite to exercise complex MultiCast/CTE scenarios.

Changes:

Remove per-pull column deep copy in MultiCastDataStreamer (switch to shared blocks + COW).
Update multiple “clear/filter” paths to respect COW via is_exclusive() checks and clone_empty() fallback.
Add a new regression test suite and expected output covering complex CTE MultiCast patterns.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
regression-test/suites/nereids_p0/cte/test_cte_multicast_complex.groovy	Adds a regression suite with multiple CTE consumers/filters to trigger MultiCast behavior.
regression-test/data/nereids_p0/cte/test_cte_multicast_complex.out	Expected results for the new regression suite.
be/src/vec/exprs/vexpr_context.cpp	Makes “filter-all” clearing COW-safe by avoiding in-place clears on shared columns.
be/src/vec/core/block.cpp	Makes `filter_block_internal`/const-filter emptying COW-safe; adds clarifying comments.
be/src/pipeline/exec/nested_loop_join_probe_operator.h	Makes block clearing COW-safe in the non-materialize path.
be/src/pipeline/exec/multi_cast_data_streamer.h / .cpp	Removes the deep-copy helper and finishes pulls without cloning columns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

doris-robot · 2026-01-30T17:45:26Z

TPC-H: Total hot run time: 32031 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f8c3a6050c0ec5e1ad9088dd6b836c99bdef64eb, data reload: false

------ Round 1 ----------------------------------
q1	17630	5300	5061	5061
q2	2045	329	229	229
q3	10164	1307	757	757
q4	10216	894	325	325
q5	7558	2169	1946	1946
q6	197	179	148	148
q7	876	733	611	611
q8	9255	1439	1108	1108
q9	5385	4821	4945	4821
q10	6847	1975	1563	1563
q11	512	287	277	277
q12	374	371	223	223
q13	17781	4079	3244	3244
q14	235	234	223	223
q15	908	826	827	826
q16	683	676	636	636
q17	657	777	532	532
q18	6941	6587	6507	6507
q19	1093	988	609	609
q20	411	350	236	236
q21	2639	2141	1868	1868
q22	366	317	281	281
Total cold run time: 102773 ms
Total hot run time: 32031 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5310	5308	5282	5282
q2	274	329	257	257
q3	2186	2676	2256	2256
q4	1386	1739	1319	1319
q5	4322	4249	4237	4237
q6	219	183	141	141
q7	2390	2079	1936	1936
q8	2608	2404	2423	2404
q9	7486	7386	7539	7386
q10	2868	3071	2634	2634
q11	562	467	464	464
q12	689	778	618	618
q13	4039	4364	3562	3562
q14	285	314	288	288
q15	897	864	812	812
q16	661	727	688	688
q17	1135	1542	1317	1317
q18	7960	8260	8041	8041
q19	949	905	835	835
q20	2060	2193	2062	2062
q21	4845	4390	4479	4390
q22	618	590	510	510
Total cold run time: 53749 ms
Total hot run time: 51439 ms

doris-robot · 2026-01-30T18:02:10Z

ClickBench: Total hot run time: 28.21 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f8c3a6050c0ec5e1ad9088dd6b836c99bdef64eb, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.04	0.04
query3	0.26	0.09	0.08
query4	1.61	0.12	0.12
query5	0.26	0.27	0.24
query6	1.17	0.68	0.68
query7	0.04	0.03	0.02
query8	0.05	0.03	0.04
query9	0.56	0.51	0.49
query10	0.55	0.54	0.56
query11	0.15	0.09	0.09
query12	0.14	0.10	0.11
query13	0.64	0.61	0.62
query14	1.06	1.05	1.05
query15	0.88	0.88	0.85
query16	0.39	0.40	0.40
query17	1.11	1.15	1.15
query18	0.22	0.20	0.21
query19	2.04	2.01	2.07
query20	0.02	0.01	0.02
query21	15.41	0.26	0.14
query22	5.17	0.06	0.04
query23	15.87	0.29	0.11
query24	1.43	0.69	0.20
query25	0.12	0.09	0.15
query26	0.14	0.15	0.13
query27	0.08	0.07	0.05
query28	4.74	1.16	0.97
query29	12.57	3.99	3.15
query30	0.28	0.13	0.11
query31	2.81	0.65	0.40
query32	3.23	0.59	0.50
query33	3.20	3.19	3.28
query34	16.30	5.40	4.74
query35	4.82	4.80	4.76
query36	0.64	0.50	0.50
query37	0.12	0.07	0.07
query38	0.07	0.04	0.04
query39	0.05	0.03	0.04
query40	0.19	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 98.73 s
Total hot run time: 28.21 s

hello-stephen · 2026-01-30T19:05:04Z

BE UT Coverage Report

Increment line coverage 54.55% (18/33) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.48% (19274/36723)
Line Coverage	35.96% (179072/497974)
Region Coverage	32.40% (139010/429052)
Branch Coverage	33.31% (60082/180359)

hello-stephen · 2026-01-30T20:26:05Z

BE Regression && UT Coverage Report

Increment line coverage 90.91% (30/33) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.52% (25746/35998)
Line Coverage	54.16% (269061/496797)
Region Coverage	51.78% (224431/433462)
Branch Coverage	53.15% (96252/181091)

zclllyybb · 2026-01-31T09:02:59Z

run buildall

hello-stephen · 2026-01-31T10:37:11Z

BE UT Coverage Report

Increment line coverage 54.55% (18/33) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.48% (19274/36723)
Line Coverage	35.95% (179029/497974)
Region Coverage	32.40% (139030/429052)
Branch Coverage	33.31% (60081/180359)

doris-robot · 2026-01-31T11:10:48Z

TPC-H: Total hot run time: 31578 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bf1e12dd2b8e3e8ee8392e620fe8a4e6de270ffa, data reload: false

------ Round 1 ----------------------------------
q1	17622	5241	5071	5071
q2	2024	304	190	190
q3	10240	1284	733	733
q4	10212	890	321	321
q5	7533	2114	1951	1951
q6	190	187	147	147
q7	853	734	594	594
q8	9261	1342	1063	1063
q9	5284	4776	4771	4771
q10	6839	1945	1556	1556
q11	533	303	281	281
q12	332	372	227	227
q13	17801	4067	3189	3189
q14	229	243	226	226
q15	902	844	809	809
q16	691	675	633	633
q17	642	790	510	510
q18	6803	6367	6472	6367
q19	1239	1009	595	595
q20	404	342	223	223
q21	2640	2126	1848	1848
q22	353	312	273	273
Total cold run time: 102627 ms
Total hot run time: 31578 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5317	5307	5339	5307
q2	280	337	246	246
q3	2143	2667	2260	2260
q4	1344	1725	1302	1302
q5	4257	4158	4230	4158
q6	216	184	139	139
q7	1873	2357	1875	1875
q8	2624	2462	2407	2407
q9	7421	7540	7506	7506
q10	2795	2968	2549	2549
q11	539	456	439	439
q12	701	776	579	579
q13	3990	4421	3500	3500
q14	304	373	278	278
q15	858	834	815	815
q16	693	732	716	716
q17	1147	1425	1399	1399
q18	7865	7933	8130	7933
q19	816	834	857	834
q20	2032	2045	1916	1916
q21	4458	4268	4155	4155
q22	603	546	514	514
Total cold run time: 52276 ms
Total hot run time: 50827 ms

doris-robot · 2026-01-31T11:22:26Z

TPC-DS: Total hot run time: 190717 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bf1e12dd2b8e3e8ee8392e620fe8a4e6de270ffa, data reload: false

query5	5006	659	511	511
query6	339	221	202	202
query7	4214	470	286	286
query8	341	258	233	233
query9	8718	2773	2801	2773
query10	473	330	290	290
query11	16454	16500	16140	16140
query12	180	120	123	120
query13	1255	434	323	323
query14	6434	3192	2995	2995
query14_1	2819	2809	2787	2787
query15	199	195	170	170
query16	991	464	457	457
query17	1071	680	599	599
query18	2597	442	330	330
query19	188	178	154	154
query20	135	125	128	125
query21	220	148	127	127
query22	4775	4873	4850	4850
query23	19178	18610	18342	18342
query23_1	18640	18595	18452	18452
query24	7206	1555	1208	1208
query24_1	1187	1197	1229	1197
query25	551	454	411	411
query26	1245	272	150	150
query27	2747	448	276	276
query28	4540	1865	1876	1865
query29	762	546	446	446
query30	311	256	232	232
query31	893	752	672	672
query32	90	76	76	76
query33	532	334	303	303
query34	902	895	556	556
query35	644	680	597	597
query36	1132	1229	1052	1052
query37	136	92	90	90
query38	2933	2915	2868	2868
query39	933	918	886	886
query39_1	872	880	875	875
query40	222	125	116	116
query41	67	62	68	62
query42	93	92	87	87
query43	433	412	377	377
query44	1329	718	710	710
query45	194	188	186	186
query46	829	958	576	576
query47	2162	2177	2070	2070
query48	294	315	233	233
query49	603	426	348	348
query50	698	262	204	204
query51	4253	4098	4095	4095
query52	89	92	82	82
query53	204	232	169	169
query54	282	267	244	244
query55	82	74	73	73
query56	294	290	303	290
query57	1376	1377	1290	1290
query58	266	255	272	255
query59	1923	2226	2087	2087
query60	326	318	311	311
query61	145	138	137	137
query62	601	567	520	520
query63	194	164	163	163
query64	4858	1127	812	812
query65	4555	4435	4462	4435
query66	1388	431	335	335
query67	17499	17673	17448	17448
query68	2429	1011	638	638
query69	415	317	286	286
query70	1015	973	968	968
query71	304	286	273	273
query72	5258	3076	2513	2513
query73	571	770	300	300
query74	9743	9558	9524	9524
query75	2455	2502	2044	2044
query76	2280	1059	667	667
query77	336	369	307	307
query78	11219	11411	10973	10973
query79	1058	875	545	545
query80	1300	494	450	450
query81	549	284	258	258
query82	1027	155	118	118
query83	324	261	243	243
query84	251	121	99	99
query85	856	456	400	400
query86	410	314	300	300
query87	3131	3082	3006	3006
query88	3479	2601	2548	2548
query89	391	335	289	289
query90	1943	178	162	162
query91	161	154	134	134
query92	74	72	67	67
query93	1039	976	571	571
query94	667	313	286	286
query95	576	394	301	301
query96	627	514	222	222
query97	2466	2518	2393	2393
query98	224	217	209	209
query99	952	916	846	846
Total cold run time: 265823 ms
Total hot run time: 190717 ms

doris-robot · 2026-01-31T11:27:33Z

ClickBench: Total hot run time: 28.29 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bf1e12dd2b8e3e8ee8392e620fe8a4e6de270ffa, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.04
query3	0.26	0.08	0.08
query4	1.62	0.11	0.10
query5	0.26	0.24	0.24
query6	1.17	0.67	0.66
query7	0.03	0.03	0.02
query8	0.06	0.04	0.05
query9	0.56	0.49	0.49
query10	0.55	0.54	0.54
query11	0.15	0.10	0.10
query12	0.14	0.10	0.11
query13	0.63	0.62	0.60
query14	1.09	1.06	1.04
query15	0.87	0.85	0.86
query16	0.38	0.39	0.38
query17	1.14	1.17	1.13
query18	0.23	0.21	0.21
query19	2.11	1.99	2.06
query20	0.02	0.01	0.01
query21	15.40	0.28	0.15
query22	5.24	0.05	0.05
query23	15.88	0.29	0.10
query24	1.45	0.28	0.60
query25	0.11	0.10	0.07
query26	0.14	0.14	0.12
query27	0.06	0.06	0.05
query28	4.95	1.14	0.97
query29	12.56	3.93	3.18
query30	0.28	0.12	0.11
query31	2.82	0.63	0.41
query32	3.24	0.58	0.49
query33	3.34	3.24	3.26
query34	16.26	5.35	4.76
query35	4.69	4.76	4.81
query36	0.64	0.49	0.49
query37	0.11	0.07	0.07
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.18	0.15	0.16
query41	0.08	0.03	0.03
query42	0.05	0.03	0.03
query43	0.05	0.05	0.04
Total cold run time: 99.08 s
Total hot run time: 28.29 s

hello-stephen · 2026-01-31T12:29:18Z

BE Regression && UT Coverage Report

Increment line coverage 90.91% (30/33) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.51% (25742/35998)
Line Coverage	54.14% (268958/496797)
Region Coverage	51.75% (224324/433462)
Branch Coverage	53.12% (96192/181091)

Gabriel39 · 2026-02-02T03:21:07Z

Paste performance results

zclllyybb · 2026-02-10T01:37:24Z

run buildall

zclllyybb force-pushed the opt_multicast branch from 5193e29 to f8c3a60 Compare January 30, 2026 16:30

zclllyybb requested review from BiteTheDDDDt, HappenLee and Copilot January 30, 2026 16:33

zclllyybb marked this pull request as ready for review January 30, 2026 16:33

Copilot started reviewing on behalf of zclllyybb January 30, 2026 16:39 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Comment thread be/src/pipeline/exec/multi_cast_data_streamer.h

zclllyybb force-pushed the opt_multicast branch from f8c3a60 to bf1e12d Compare January 31, 2026 09:02

zclllyybb changed the title ~~[Opt](operator) Eliminate redundant copy in MultiCastOperator~~ [Opt](operator) Eliminate redundant copy in MultiCastOperator and fix wrong assume_mutable Feb 2, 2026

zclllyybb marked this pull request as draft February 6, 2026 02:25

add test, add check, fix misuses

bc48996

test assert_mutable

231e35e

zclllyybb force-pushed the opt_multicast branch from bf1e12d to 231e35e Compare February 10, 2026 01:37

Conversation

zclllyybb commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jan 30, 2026

Uh oh!

zclllyybb commented Jan 30, 2026

Uh oh!

doris-robot commented Jan 30, 2026

Uh oh!

doris-robot commented Jan 30, 2026

Uh oh!

doris-robot commented Jan 30, 2026

Uh oh!

doris-robot commented Jan 30, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Jan 30, 2026

BE Regression && UT Coverage Report

Uh oh!

zclllyybb commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

doris-robot commented Jan 30, 2026

Uh oh!

doris-robot commented Jan 30, 2026

Uh oh!

hello-stephen commented Jan 30, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Jan 30, 2026

BE Regression && UT Coverage Report

Uh oh!

zclllyybb commented Jan 31, 2026

Uh oh!

hello-stephen commented Jan 31, 2026

BE UT Coverage Report

Uh oh!

doris-robot commented Jan 31, 2026

Uh oh!

doris-robot commented Jan 31, 2026

Uh oh!

doris-robot commented Jan 31, 2026

Uh oh!

hello-stephen commented Jan 31, 2026

BE Regression && UT Coverage Report

Uh oh!

Gabriel39 commented Feb 2, 2026

Uh oh!

zclllyybb commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zclllyybb commented Jan 30, 2026 •

edited

Loading