Skip to content

[refactor](cloud) improve FDB transaction approximate size calculation accuracy#60390

Merged
yiguolei merged 2 commits intoapache:branch-4.0from
w41ter:pick/60351_to_branch_4.0
Mar 3, 2026
Merged

[refactor](cloud) improve FDB transaction approximate size calculation accuracy#60390
yiguolei merged 2 commits intoapache:branch-4.0from
w41ter:pick/60351_to_branch_4.0

Conversation

@w41ter
Copy link
Copy Markdown
Contributor

@w41ter w41ter commented Jan 30, 2026

Cherry-pick #60351 to branch-4.0

Original PR:

  • refactor improve FDB transaction approximate size calculation accuracy

Refactored the approximate size calculation in the Transaction class to align with FoundationDB's actual implementation in ReadYourWrites.actor.cpp.

@w41ter
[refactor](cloud) improve FDB transaction approximate size calculatio…
cd923fb 
…n accuracy

Refactored the approximate size calculation in Transaction class to align with
FoundationDB's actual implementation in ReadYourWrites.actor.cpp.
@w41ter w41ter requested a review from yiguolei as a code owner January 30, 2026 08:44
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Jan 30, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring
Copy link
Copy Markdown
Contributor

dataroaring commented Jan 31, 2026

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Jan 31, 2026

Cloud UT Coverage Report

Increment line coverage 100.00% (36/36) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.26% (1789/2257)
Line Coverage 64.84% (31838/49101)
Region Coverage 65.46% (15887/24269)
Branch Coverage 55.99% (8436/15068)

yiguolei
yiguolei previously approved these changes Feb 3, 2026
View reviewed changes
@w41ter
Copy link
Copy Markdown
Contributor Author

w41ter commented Feb 9, 2026

run buildall

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Feb 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 11, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 11, 2026

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Feb 11, 2026

Cloud UT Coverage Report

Increment line coverage 100.00% (28/28) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.19% (1788/2258)
Line Coverage 64.75% (31733/49011)
Region Coverage 65.40% (15844/24225)
Branch Coverage 55.92% (8406/15032)

@w41ter w41ter requested a review from yiguolei February 12, 2026 07:34
@yiguolei yiguolei merged commit e0690d0 into apache:branch-4.0 Mar 3, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@w41ter @Thearas @dataroaring @doris-robot @hello-stephen @gavinchou @yiguolei