[cleanup](build) Replace runtime_state.h include with forward declaration in 14 headers#61549
Open
shuke987 wants to merge 2 commits intoapache:masterfrom
Open
[cleanup](build) Replace runtime_state.h include with forward declaration in 14 headers#61549shuke987 wants to merge 2 commits intoapache:masterfrom
shuke987 wants to merge 2 commits intoapache:masterfrom
Conversation
…ation in 14 headers In 14 header files, runtime_state.h was included but RuntimeState was only used as a pointer/reference parameter. Replace with forward declaration to reduce header dependency fan-out and improve incremental build times. For header-only files, added "class RuntimeState;" forward declaration. For files with corresponding .cpp, ensured the .cpp has the full include. Verified: full BE build passes with zero compilation errors.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
shuke987
requested review from
BiteTheDDDDt and
yiguolei
and removed request for
yiguolei
Collaborator
Author
|
run buildall |
Move #include "runtime/runtime_state.h" to correct position in project includes section and expand single-line namespace to multi-line format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
run buildall |
TPC-H: Total hot run time: 27060 ms |
TPC-DS: Total hot run time: 168118 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include "runtime/runtime_state.h"withclass RuntimeState;forward declaration in 14 header filesRuntimeState*as pointer/reference parameters — they never access RuntimeState members or methods.cpp, the full#includeis preserved in the.cppThis reduces the transitive include fan-out from
runtime_state.h, which pulls in heavy protobuf/thrift generated headers. This should improve incremental build times for files that depend on these 14 headers.Modified headers:
hash_table_set_build.h,runtime_filter_producer_helper_{cross,set}.h,tablet_sink_hash_partitioner.h,lambda_function.h,short_circuit_evaluation_expr.h,vcolumn_ref.h,vcondition_expr.h,vectorized_fn_call.h,vexpr_context.h,vtopn_pred.h,task_execution_context.h,collection_statistics.h,ann_topn_runtime.h,rowset_reader_context.hTest plan
🤖 Generated with Claude Code